[core] Improve GitHub bug reproduction template #5067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joserodolfofreitas
added
core
|
These are the results for the performance tests:
|
alexfauquette
approved these changes
Jun 1, 2022
oliviertassinari
changed the title
flaviendelangle
approved these changes
Jun 13, 2022
1 task
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
joserodolfofreitas
force-pushed
the
update-github-bug-template
branch
from
ac9b051 to
8fcc7f5
Compare
github-actions
bot
removed
the
PR: out-of-date
| Include code to reproduce, if relevant (which it most likely is). | ||
| Please provide a link to a live example and an unambiguous set of steps to reproduce this bug. | ||
|
|
||
| As a starting point, we recommend you browse our [documentation](https://mui.com/x/advanced-components/), and [select](https://mui.com/static/docs/forking-an-example.png) the closest example to your use case. |
There was a problem hiding this comment.
This link is a 301
Suggested change
| As a starting point, we recommend you browse our [documentation](https://mui.com/x/advanced-components/), and [select](https://mui.com/static/docs/forking-an-example.png) the closest example to your use case. | |
| As a starting point, we recommend you browse our [documentation](https://mui.com/x/introduction/), and [select](https://mui.com/static/docs/forking-an-example.png) the closest example to your use case. |
There was a problem hiding this comment.
"the documentation". We document ourselves here 😁
Suggested change
| As a starting point, we recommend you browse our [documentation](https://mui.com/x/advanced-components/), and [select](https://mui.com/static/docs/forking-an-example.png) the closest example to your use case. | |
| As a starting point, we recommend you [browse the documentation](https://mui.com/x/introduction/), and [select](https://mui.com/static/docs/forking-an-example.png) the closest example to your use case. |
| @@ -8,6 +8,7 @@ | |||
| /r/x-license-eula https://mui.com/store/legal/mui-x-eula/ 302 | |||
| /r/x-license-key-installation https://mui.com/x/advanced-components/#license-key-installation 302 | |||
| /r/x-data-grid-no-dimensions https://mui.com/x/react-data-grid/layout/ 302 | |||
| /r/x-issue-template https://codesandbox.io/s/mui-x-issue-template-uh3pm2 302 | |||
There was a problem hiding this comment.
Please move the codesandbox under the MUI organization, so others can modify it later on.
There was a problem hiding this comment.
For example, we likely want to fix:
so developers can start from a clean state.
| You can use the official codesandbox template of the [DataGrid](https://codesandbox.io/s/datagrid-v5-quick-start-54iz1) or [DataGridPro](https://codesandbox.io/s/datagridpro-v5-quick-start-5pjhc) as a starting point. | ||
|
|
||
| If you have an issue concerning TypeScript please start from this TypeScript playground: https://mui.com/r/ts-issue-template. | ||
| Or you can use a [basic template](https://mui.com/r/x-issue-template) to build your reproduction case. |
There was a problem hiding this comment.
Would it feel better without the blank line before "Or you can use"?
joserodolfofreitas
added a commit
to joserodolfofreitas/mui-x
that referenced
this pull request
Jul 15, 2022
Instead of adding templates for the different components, we'll suggest to fork a demo close to the user use case.
alexfauquette
pushed a commit
to alexfauquette/mui-x
that referenced
this pull request
Aug 26, 2022
Instead of adding templates for the different components, we'll suggest to fork a demo close to the user use case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of adding templates for the different components, we'll suggest to fork a demo close to the user use case.