Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Update monorepo #4854

Merged
merged 3 commits into from
May 12, 2022
Merged

Conversation

cherniavskii
Copy link
Member

@@ -21,6 +21,7 @@ const alias = {
'@mui/docs': '../node_modules/@mui/monorepo/packages/mui-docs/src',
'@mui/markdown': '../node_modules/@mui/monorepo/docs/packages/markdown',
'@mui/monorepo': '../node_modules/@mui/monorepo',
'@mui/joy': '../node_modules/@mui/monorepo/packages/mui-joy/src',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_document in monorepo started to use @mui/joy in mui/material-ui#32576

Initially, I wanted to add @mui/joy dependency to our docs/package.json, but it can get out of sync with monorepo quickly. I think using alias is a better.

@cherniavskii cherniavskii added the core Infrastructure work going on behind the scenes label May 12, 2022
@mui-bot
Copy link

mui-bot commented May 12, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 259.2 487.4 345.1 352.18 87.773
Sort 100k rows ms 428 817.3 628.4 632.68 131.575
Select 100k rows ms 98.7 218.8 205.5 170.04 46.27
Deselect 100k rows ms 104 203 172.6 160.36 35.355

Generated by 🚫 dangerJS against a52d3cd

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to me.

@cherniavskii cherniavskii merged commit d494668 into mui:master May 12, 2022
@cherniavskii cherniavskii deleted the update-monorepo branch May 12, 2022 13:41
@cherniavskii cherniavskii mentioned this pull request May 12, 2022
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
* bump monorepo

* add alias for @mui/joy

* use MuiPage type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants