Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add joy to docs package.json #32744

Merged
merged 1 commit into from
May 12, 2022
Merged

Conversation

siriwatknp
Copy link
Member

Pointed out by @cherniavskii in #32576 (comment)

@siriwatknp siriwatknp added the docs Improvements or additions to the documentation label May 12, 2022
@siriwatknp siriwatknp requested a review from cherniavskii May 12, 2022 03:29
@mui-bot
Copy link

mui-bot commented May 12, 2022

No bundle size changes

Generated by 🚫 dangerJS against 91ec131

@cherniavskii
Copy link
Member

Hmm, it didn't work as I expected, since dependencies are installed automatically from top-level package.json only (not docs/package.json).

We can add @mui/joy to our package.json, but I don't like this approach since there's a high chance it'll get out of sync.

I tried this in MUI X repo and it works:

index 2e5cc5027..773d6cb24 100644
--- a/docs/babel.config.js
+++ b/docs/babel.config.js
@@ -21,6 +21,7 @@ const alias = {
   '@mui/docs': '../node_modules/@mui/monorepo/packages/mui-docs/src',
   '@mui/markdown': '../node_modules/@mui/monorepo/docs/packages/markdown',
   '@mui/monorepo': '../node_modules/@mui/monorepo',
+  '@mui/joy': '../node_modules/@mui/monorepo/packages/mui-joy/src',
   docs: '../node_modules/@mui/monorepo/docs', // TODO remove
   docsx: './',
 };

What do you think? @flaviendelangle @m4theushw @oliviertassinari

@cherniavskii
Copy link
Member

I've opened a PR in MUI X repo to address this mui/mui-x#4854
@siriwatknp change in docs/package.json is not necessary for MUI X, but if you think it still makes sense - feel free to merge this PR

@siriwatknp siriwatknp merged commit c70baf8 into mui:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants