-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Cleanup issues body #10372
[core] Cleanup issues body #10372
Conversation
}); | ||
|
||
const text = | ||
'### Duplicates\r\n\r\n- [X] I have searched the existing issues\r\n\r\n### Latest version\r\n\r\n- [X] I have tested the latest version\r\n\r\n'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github seems to store newlines using windows conventions.
Netlify deploy previewNetlify deploy preview: https://deploy-preview-10372--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
Would it work if we add - type: markdown
attributes:
value: <!-- delete:start -->
# checkboxes ...
- type: markdown
attributes:
value: <!-- delete:end --> And postprocess them with const body = issue.data.body
.replaceAll('<!-- delete:start -->', '<!--')
.replaceAll('<!-- delete:end -->', '-->') Doesn't seem much more complicated, it doesn't have to be kept in sync with the template strings, and directly reusable in other templates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. Commented with an alternative implementation. But fine to merge as is as well.
That's a neat idea, but we often edit issues main comment along the way, and leaving those comments in there would still be a bit annoying. But it's trivial to update in the future so I'll merge as is for now. |
Perhaps then we could do const body = issue.data.body.replaceAll(/<!-- delete:start -->(\n|.)*?<!-- delete:end -->/g, '') ? I think we still should combine the headers. And did you give this some thought? My personal feeling is that the solution in this PR is the least favourable of the shaping page. |
Closes #10340
Remove the checkboxes from new issues' body. I have hardcoded the strings, seems good enough.
Result: https://github.com/romgrk/mui-test-issue-cleanup/issues/3