Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Improve GitHub template #10340

Closed
oliviertassinari opened this issue Sep 14, 2023 · 5 comments · Fixed by #10372
Closed

[core] Improve GitHub template #10340

oliviertassinari opened this issue Sep 14, 2023 · 5 comments · Fixed by #10372
Labels
scope: code-infra Specific to the core-infra product

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 14, 2023 •
edited
Loading

As of today, creating a new issue leads to an annoying doubleheader, it takes vertical space that readers can skip.

Screenshot 2023-09-14 at 19 47 59

What if we replaced this for a single header?

See how the lighthouse feels better: GoogleChrome/lighthouse#15450.

Screenshot 2023-09-14 at 19 49 10

I have seen Toolpad (@Janpot can't find which issue again) complain about this as well, so feels like we might be able to improve this for the whole MUI org.
@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Sep 14, 2023
@oliviertassinari oliviertassinari added the scope: code-infra Specific to the core-infra product label Sep 14, 2023
@romgrk
Copy link
Contributor

romgrk commented Sep 14, 2023 •
edited
Loading

I had proposed to remove the sections altogether with a bot that would run right after the issue is opened, I don't like the noise. There is a notion page somewhere about this.

@romgrk romgrk removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Sep 14, 2023
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Sep 15, 2023 •
edited
Loading

There is a notion page somewhere about this.

Ah, found it: https://www.notion.so/mui-org/Github-Action-to-remove-issue-template-checkboxes-a1abe3824bf04bbf9dc62d876767fe92

@Janpot
Copy link
Member

Janpot commented Sep 15, 2023

We could combine the headers as a short term solution and keep the notion page to shape a long term solution?

@romgrk
Copy link
Contributor

romgrk commented Sep 15, 2023

It shouldn't be too long to write an action for that. I'll explore next week.

@romgrk romgrk mentioned this issue Sep 17, 2023
Merged
@romgrk
Copy link
Contributor

romgrk commented Sep 17, 2023

Yes it was really trivial to write, see details in #10372.

@oliviertassinari oliviertassinari mentioned this issue Dec 24, 2023
Merged
@michelengelen michelengelen removed their assignment Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[core] Cleanup issues body romgrk/mui-x
4 participants
@romgrk @Janpot @oliviertassinari @michelengelen