Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Click with TouchTap everywhere in the API and in docs #771

Merged
merged 2 commits into from
Jun 7, 2015
Merged

Replace Click with TouchTap everywhere in the API and in docs #771

merged 2 commits into from
Jun 7, 2015

Conversation

pomerantsev
Copy link
Contributor

Fixes #769
Fixes #770

@pomerantsev
Copy link
Contributor Author

@hai-cea I guess we could still think about removing onItemClick from menu, since now all other components only support onTouchTap.
If we do so, #641 can be closed as well.
But maybe it's not a big deal - what's your opinion?

@hai-cea
Copy link
Member

hai-cea commented Jun 7, 2015

@pomerantsev Since this PR will introduce a breaking change, I think we should go ahead and remove onItemClick from menu as well. Would you like to do it in this PR?

@pomerantsev
Copy link
Contributor Author

@hai-cea Sure! Done.

hai-cea pushed a commit that referenced this pull request Jun 7, 2015
Merge pull request #771 from pomerantsev/fix/tap-instead-of-click
ba84faf 
Replace Click with TouchTap everywhere in the API and in docs
@hai-cea hai-cea merged commit ba84faf into mui:master Jun 7, 2015
@hai-cea
Copy link
Member

hai-cea commented Jun 7, 2015

Thanks @pomerantsev !

@hai-cea hai-cea mentioned this pull request Jun 7, 2015
Closed
@pomerantsev pomerantsev deleted the fix/tap-instead-of-click branch June 8, 2015 06:25
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Nov 10, 2020
@dmtrKovalenko
Merge pull request mui#771 from dmtrKovalenko/feature/form-example
3b9f9b4 
Feature/form example
@zannager zannager added the docs Improvements or additions to the documentation label Mar 14, 2023
@akashmitra akashmitra mentioned this pull request Jun 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Click is used in the name of a prop in DropDownIcon onClick is used instead of onTouchTap in docs
3 participants
@pomerantsev @hai-cea @zannager