Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu API contains props that almost duplicate each other #775

Closed
pomerantsev opened this issue Jun 7, 2015 · 0 comments
Closed

Menu API contains props that almost duplicate each other #775

pomerantsev opened this issue Jun 7, 2015 · 0 comments
Labels
support: docs-feedback Feedback from documentation page

Comments

@pomerantsev
Copy link
Contributor

onItemClick and onItemTap do pretty much the same thing, and it might get confusing why you should prefer one over the other.
With only one property (where the handler would react to the click / tap instantly, without a 300ms delay) the API would be more consistent and slightly easier to understand.

@hai-cea hai-cea closed this as completed in 89737d4 Jun 7, 2015
mnajdova pushed a commit to mnajdova/material-ui that referenced this issue Nov 10, 2020
mnajdova pushed a commit to mnajdova/material-ui that referenced this issue Nov 10, 2020
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@zannager zannager added support: docs-feedback Feedback from documentation page and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support: docs-feedback Feedback from documentation page
Projects
None yet
Development

No branches or pull requests

3 participants