Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AppBar] Fix onLeftIconButtonTouchTap event #5237

Closed
wants to merge 7 commits into from
Closed

[AppBar] Fix onLeftIconButtonTouchTap event #5237

wants to merge 7 commits into from

Conversation

pratimary
Copy link

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Bound the onClick event of the leftIconButton in AppBar to the onLeftIconButtonTouchTap event.
Fixes issue #2482

@muibot muibot added PR: Needs Review PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels Sep 22, 2016
@pratimary pratimary closed this Sep 22, 2016
@pratimary pratimary deleted the fix-onLeftIconButtonTouchTap-appBar branch September 22, 2016 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pratimary @muibot