Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox ripple causes generation of invalid hitbox #5150

Closed
harmony7 opened this issue Sep 8, 2016 · 1 comment
Closed

Checkbox ripple causes generation of invalid hitbox #5150

harmony7 opened this issue Sep 8, 2016 · 1 comment
Labels
bug 🐛 Something doesn't work

Comments

@harmony7
Copy link

harmony7 commented Sep 8, 2016

Problem description

Once a checkbox is clicked, the space occupied by the ripple animation turns into a new hitbox that will trigger additional ripples but will not affect the value of the checkbox.

Steps to reproduce

This can be seen on http://www.material-ui.com/#/components/checkbox

Hover the mouse a few pixels to the left of the first checkbox labeled "Simple". Move the mouse over to the checkbox. Note that the cursor turns into a hand as it comes in contact with the checkbox.

Now click, and you will see the ripple animation. Note the size of the ripple. Now, move the mouse a few more pixels to the left and you will notice that the mouse cursor will stay as the hand at a greater distance away from the checkbox --- all the way up to the size of the ripple.
Click within this area, inside the box caused by the ripple but outside the checkbox itself. You will see additional ripples being generated, but the state of the checkbox is not affected.

This also happens on mobile devices. You are able to touch the area outside the checkbox once the ripple is generated, to trigger further ripple animations that don't affect the checkbox state.

Since the ripples are supposed to be confirmation of touch, this is confusing and gives the illusion of checkboxes sometimes not being responsive. In my use case I have chosen to disable the ripples for now as a workaround.

Versions

  • Material-UI: 0.16 (or whatever is used on the material-ui demo site)
  • React: 15 (or whatever is used on the material-ui demo site)
  • Browser: Safari/Chrome for Mac, Safari/Chrome for iOS, Edge for Windows
pratimary pushed a commit to pratimary/material-ui that referenced this issue Sep 15, 2016
pratimary pushed a commit to pratimary/material-ui that referenced this issue Sep 16, 2016
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Dec 4, 2016
@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 4, 2016

I confirm the issue:
issue
I have dug into it using #5191 as a starting point.
Implementing a proper fix would require changing quite some stuff.
It turns out, that issue was solved by @nathanmarks on the next branch:

fixed

I'm closing the issue, I don't think it worth spending more time on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

No branches or pull requests

2 participants