Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Fix flaky dashboard screenshot - take 2 #43937

Merged
merged 5 commits into from
Oct 1, 2024
Merged

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Sep 29, 2024

Still seeing flakyness after #43890. I could reproduce locally after switching the scrollbar visibility setting on my laptop. Just disabling overflow on the body seems to fix it reliably for any of the settings. There is now also a noticable difference in all screenshots of elements that overflow. Looks like this change is an improvement for those screenshots as well.

Doing the same for pigment regression tests.

Make sure to check out the changed screenshots

@Janpot Janpot added test scope: code-infra Specific to the core-infra product labels Sep 29, 2024
@mui-bot
Copy link

mui-bot commented Sep 29, 2024

Netlify deploy preview

https://deploy-preview-43937--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 5e58d63

@Janpot Janpot marked this pull request as ready for review September 30, 2024 07:14
@Janpot Janpot requested a review from mnajdova September 30, 2024 07:16
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense. Let's try this and see how it will behave

@Janpot Janpot merged commit 90f0ce2 into mui:master Oct 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants