[code-infra] Fix flaky dashboard screenshot #43890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-43890--material-ui.netlify.app/ Bundle size report |
This was referenced Oct 25, 2024
This was referenced Oct 29, 2024
This was referenced Oct 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been debugging the flakyness of the dashboard screenshot. After throttling the playwright browser, it becomes apparent there is a horizontal layout shift while running the test:
Screen.Recording.2024-09-26.at.10.24.13.mov
This shift doesn't happen when just visiting the page. Debugging further reveals that it is caused by the
page.screenshotcall. Apparently, playwright hides scrollbars when taking the screenshot. It looks like there's a race condition between the responsive charts reacting to a width change and playwright capturing the page. This causes a flaky screenshot.It looks like we can remedy this by always hiding scrollbars, through the--hide-scrollbarsflag.This causes every scrollbar to disappear
It looks like we can remedy this by always hiding the scrollbar on the
body.Screen.Recording.2024-09-26.at.10.28.25.mov