[docs] Fix Sign-in template form experience #43838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-43838--material-ui.netlify.app/ Bundle size report |
oliviertassinari
force-pushed
the
fix-sign-in-submit
branch
from
1ae8b56
to
dac5b90
Compare
aarongarciah
approved these changes
Sep 23, 2024
This was referenced Oct 25, 2024
This was referenced Oct 29, 2024
This was referenced Oct 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UX on https://mui.com/material-ui/getting-started/templates/sign-in/ is not usable in production, at least for people like me. Pressing Enter on the password field should submit the form, not trigger the forgot password flow.
Screen.Recording.2024-09-21.at.19.19.18.mov
It was OK in https://v5.mui.com/material-ui/getting-started/templates/sign-in/. This was broken in #41192. I think this case, the ones in #41469 (umbrella of #42609), and the execution in https://tremor.so/ illustrate that we should have the review from an engineer too on each template change.
I'm going straight to a PR, it feels important. I also want to make it so the form submits so we can more easily have a place where we can test auto-fill logic, see #39539.
Preview: https://deploy-preview-43838--material-ui.netlify.app/material-ui/getting-started/templates/