-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui] Refine the Sign-in and Sign-up templates #41192
Conversation
Netlify deploy previewhttps://deploy-preview-41192--material-ui.netlify.app/ Bundle size report |
docs/data/material/getting-started/templates/sign-in-side/SignInSide.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in-side/SignInSide.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in-side/SignInSide.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in-side/SignInSide.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in-side/SignInSide.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in-side/getSignInSideTheme.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in/SignIn.tsx
Outdated
Show resolved
Hide resolved
docs/public/static/images/templates/templates-images/dark-background.png
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in/SignIn.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in/SignIn.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in/SignIn.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in/SignIn.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in/SignIn.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in/SignIn.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in/SignIn.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in/SignIn.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in/SignIn.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in/SignIn.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in/SignIn.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in/SignIn.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in-side/SignInSide.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in-side/ToggleColorMode.js
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in-side/SignInSide.js
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in-side/CustomIcons.js
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in-side/CustomIcons.js
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in-side/Content.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in-side/Content.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in-side/Content.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Thanks for bearing with me on all the reviews 🤝 Last "major" request is to add labels to all the input fields so they're accessible. We can't rely on just the placeholder. This will naturally increase the height of all of the cards, so keep an eye out for mobile scrolling (everything should be fine, though).
docs/data/material/getting-started/templates/sign-in-side/SignInSide.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of #37555
This PR is for refining the Sign-in and Sign-out templates, to be aligned with the new landing page theme.
👉 https://deploy-preview-41192--material-ui.netlify.app/material-ui/getting-started/templates/sign-in/
👉 https://deploy-preview-41192--material-ui.netlify.app/material-ui/getting-started/templates/sign-up/
👉 https://deploy-preview-41192--material-ui.netlify.app/material-ui/getting-started/templates/sign-in-side/