Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the rem unit. #433

Closed
wants to merge 1 commit into from
Closed

Use the rem unit. #433

wants to merge 1 commit into from

Conversation

a1russell
Copy link

Specifically, replace usages of the px unit with rem or, when it seems more appropriate, the em unit.

Mixins are used to keep the px unit as a fallback, in case browser compatibility is a concern.

A new variable, @root-font-size, is used to set the font-size of the html element to 10px.

Specifically, replace usages of the `px` unit with `rem` or, when it
seems more appropriate, the `em` unit.
@a1russell a1russell mentioned this pull request Mar 16, 2015
Closed
@a1russell
Copy link
Author

Do you have any feedback for me? Is there a possibility of merging this at all?

@mmrtnz
Copy link
Contributor

mmrtnz commented Mar 25, 2015

@a1russell All styles will be moved inline after our css refactoring is released within the next 2-3 weeks, so these changes would soon be over written. Google Material Design specs use dp and sp when laying out components like in this example. We would have to make the switch after refactoring is complete.

@mmrtnz mmrtnz closed this Mar 25, 2015
@RangerMauve
Copy link

Any news on when something like this could be integrated? The current font size is too small for my users and increasing it is proving to be a pain.

@zannager zannager added docs Improvements or additions to the documentation customization: theme Centered around the theming features labels Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customization: theme Centered around the theming features docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants