-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rem #234
Comments
I definitely agree with this suggestion. I prefer thinking in relative sizes rather than in pixels, especially since responsive design became popular. A good article I read on the subject a while back: http://csswizardry.com/2011/12/measuring-and-sizing-uis-2011-style/ |
I just opened a pull request for this: #433. |
@whodidthis @a1russell does #248 help? |
@shaurya947 Are you asking if |
My bad @a1russell, I actually meant to link to #2039. Sorry to hear that buddy! Let's just see where 2039 goes, and if we need to make any changes to it.. |
@shaurya947: Ah, okay, gotcha. Looks like #2039 is similar to what I was trying to achieve, at least for one component. I haven't looked at this project since my PR was rejected, though, so I'm not sure if it covers everything. But it does look to be a step in the right direction. Best of luck! |
Not sure if brought up before but I was thinking using rem instead of pixels might be closer to android's dp sizing. Then you could use media query break points, set up a suitable font size at root and everything would scale. It's not going to be as accurate as android's dp but would help a lot. Current px values would work as fallback.
The text was updated successfully, but these errors were encountered: