Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rem #234

Closed
whodidthis opened this issue Jan 13, 2015 · 6 comments
Closed

Rem #234

whodidthis opened this issue Jan 13, 2015 · 6 comments
Labels
docs Improvements or additions to the documentation

Comments

@whodidthis
Copy link

Not sure if brought up before but I was thinking using rem instead of pixels might be closer to android's dp sizing. Then you could use media query break points, set up a suitable font size at root and everything would scale. It's not going to be as accurate as android's dp but would help a lot. Current px values would work as fallback.

@a1russell
Copy link

I definitely agree with this suggestion. I prefer thinking in relative sizes rather than in pixels, especially since responsive design became popular. A good article I read on the subject a while back: http://csswizardry.com/2011/12/measuring-and-sizing-uis-2011-style/

@a1russell
Copy link

I just opened a pull request for this: #433.

@shaurya947
Copy link
Contributor

@whodidthis @a1russell does #248 help?

@a1russell
Copy link

@shaurya947 Are you asking if em is preferable to px in lieu of rem, I'd say yes; however, I would still have preferred rem. But I'm not going to re-do #433 if that's what you're asking. It was a lot of work, and it got me nothing.

@shaurya947
Copy link
Contributor

My bad @a1russell, I actually meant to link to #2039.

Sorry to hear that buddy! Let's just see where 2039 goes, and if we need to make any changes to it..

@a1russell
Copy link

@shaurya947: Ah, okay, gotcha. Looks like #2039 is similar to what I was trying to achieve, at least for one component. I haven't looked at this project since my PR was rejected, though, so I'm not sure if it covers everything. But it does look to be a step in the right direction. Best of luck!

@zannager zannager added the docs Improvements or additions to the documentation label Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

No branches or pull requests

4 participants