-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Updating Charts demo with real charts usage for MUI X marketing page #38317
Conversation
This is awesome! Those color palettes really pop! 🤩 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, this is looking great!
Instead of stacking up two different types of charts, and making the demo container a bit too tall, what do you think of adding chips there so visitors can click on them to see each one? I know there's the downside of having to interact with it to see a different type of chart, but it'd certainly make the overall section/page more polished!
Love the new designs! I can probably address that in a later PR? Possibly before a beta or stable release? I wanted to get this one quickly out and not spend too much time on it. @danilo-leal |
A quick look at it:
It feels like the colors could be lighter and the font size less bold, for example, this would feel better on my end (to give an idea).
So I suspect it would be better to change the default look in https://mui.com/x/react-charts/areas-demo/#simpleareachart cc @gerdadesign & @alexfauquette, I don't know if this is feedback that surfaced before. What do you think? I hear that for data engineering, it's also frequent to see the opposite https://matplotlib.org/stable/plot_types/basic/stackplot.html#sphx-glr-plot-types-basic-stackplot-py, https://vizzingdata.com/discrete-continuous-area-charts/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pushing it
Added small refinements. Their is still an issue with tootlip opacity due to the docs theming
https://github.com/mui/material-ui/blob/a172994c2e15c91a1879897f84d4a711914e5f36/docs/src/modules/brandingTheme.ts/#L968-L969
About opacity, I don't know. From a DX point of view, I think it's easier to have opacity and let dev add an opacity
property than having one encoded in the colors
Netlify deploy previewhttps://deploy-preview-38317--material-ui.netlify.app/ Bundle size report |
Should I merge this before the release? |
We can skip this merge for the next release. I would like to wait for one more sign-off from @danilo-leal or @oliviertassinari. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, it makes sense to iterate on a more complex demo later!
Just wondering if we shouldn't choose just one of the two charts to preserve the overall section's height ⎯ but aside from this, it's good to go, much better having the real component than illustrations!
@alexfauquette We could use plain rga color (and not rgba) combined with
What about this one? |
I dont think it looks too bad. I also looked at the other components and they seem to exceed the height as well. |
Yeah, all of them exceed it by a little, which is definitely not a problem ⎯ just that the Charts will exceed it more than I'd ideally like (the Date Range is already a bit too tall for me but doable). Not a blocker for this immediate release but looking forward to iterating more on it in the near future! |
…ting page (#38317) Co-authored-by: Rich Bustos <[email protected]> Co-authored-by: alexandre <[email protected]>
Updating the Charts demo in MUI X landing page with real Charts usage. We were previously using images.
This is a continuation of #38027 and @alexfauquette work on #37609.
Preview: https://deploy-preview-38317--material-ui.netlify.app/x/
Before:
After: