[website] Update Demo footers on MUI X landing page #38027
Conversation
richbustos
requested review from
joserodolfofreitas,
oliviertassinari,
danilo-leal and
samuelsycamore
richbustos
added
the
website
oliviertassinari
changed the title
Netlify deploy previewhttps://deploy-preview-38027--material-ui.netlify.app/ Bundle size report |
| <Grid container spacing={1} justifyContent="center"> | ||
| <Grid item xs={6}> | ||
| <Box sx={{ width: { xs: 200, sm: 240 }, maxWidth: '100%', ml: 'auto' }}> | ||
| <AspectRatioImage src="/static/branding/mui-x/chart-light1.png" ratio={219 / 120} /> | ||
| </Box> | ||
| </Grid> | ||
| <Grid item xs={6}> | ||
| <Box sx={{ width: { xs: 200, sm: 240 }, maxWidth: '100%', mr: 'auto' }}> | ||
| <AspectRatioImage src="/static/branding/mui-x/chart-light2.png" ratio={219 / 120} /> | ||
| </Box> | ||
| </Grid> | ||
| <Grid item xs={6}> | ||
| <Box sx={{ width: { xs: 200, sm: 240 }, maxWidth: '100%', ml: 'auto' }}> | ||
| <AspectRatioImage src="/static/branding/mui-x/chart-light3.png" ratio={219 / 120} /> | ||
| </Box> | ||
| </Grid> | ||
| <Grid item xs={6}> | ||
| <Box sx={{ width: { xs: 200, sm: 240 }, maxWidth: '100%', mr: 'auto' }}> | ||
| <AspectRatioImage src="/static/branding/mui-x/chart-light4.png" ratio={219 / 120} /> | ||
| </Box> | ||
| </Grid> | ||
| </Grid> |
There was a problem hiding this comment.
What if we were rendering our charts now?
There was a problem hiding this comment.
I can potentially do that in another PR? I just wanted to address updating the footer on the demos since it was requested
There was a problem hiding this comment.
Just pushed a few changes that add a title + description to the Charts, Date Range, and Tree View sections, just so they aren't as dry as they're now ⎯ @richbustos feel free to tweak/fix/improve the copy anyway you want! Additionally, also swapped the images of the Charts out for images of the actual components that we now provide, but later on, it would definitely be nice to actually render them as @oliviertassinari suggested.
Agree that could be done in a separate PR, though, just to have this out faster in the meantime!
I think for now this is looking good on my end ⎯ any further tweaks could be done iteratively!
| Charts | Tree View | Date Range |
|---|---|---|
 |
 |
 |
|
Awesome! Thanks @danilo-leal! |
What?
Update Demo footers on MUI X landing page. Charts and Date Range Picker demos have outdated information. Charts is in Alpha and Date Range Pickers has been stable since Sept 2022.
This change was requested in here (#37966)
I also seperated out the demos in a separate file.
https://deploy-preview-38027--material-ui.netlify.app/x/