Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][base] Move styles to the bottom of demos code for FormControl #36579

Merged
merged 3 commits into from
Apr 3, 2023
Merged

[docs][base] Move styles to the bottom of demos code for FormControl #36579

merged 3 commits into from
Apr 3, 2023

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Mar 20, 2023 •
edited by mnajdova
Loading

Part of #36498

This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

@mui-bot
Copy link

mui-bot commented Mar 20, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-36579--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 591ffa9

@gitstart gitstart marked this pull request as ready for review March 20, 2023 08:58
@gitstart
Copy link
Contributor Author

@michaldudak this PR is ready for review

@zannager zannager added docs Improvements or additions to the documentation package: base-ui Specific to @mui/base component: FormControl The React component labels Mar 20, 2023
@zannager zannager requested a review from michaldudak March 20, 2023 10:21
@hbjORbj hbjORbj changed the title MUI-36498 - [docs][base][Form-Control] Move styles to the bottom of demos code [docs][base] Move styles to the bottom of demos code for FormControl Mar 20, 2023
@ZeeshanTamboli ZeeshanTamboli mentioned this pull request Mar 31, 2023
Closed
13 tasks
ZeeshanTamboli
ZeeshanTamboli reviewed Mar 31, 2023
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the UseFormControl demo files to move the calling component to the top even though the demo does not have any styles? It looks easier to read if it's on top.

@gitstart
Copy link
Contributor Author

gitstart commented Apr 1, 2023

@ZeeshanTamboli your feedback has been implemented.

@gitstart gitstart requested a review from ZeeshanTamboli April 1, 2023 11:34
@ZeeshanTamboli ZeeshanTamboli merged commit 1f23d4c into mui:master Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

@michaldudak michaldudak Awaiting requested review from michaldudak

Assignees
No one assigned
Labels
component: FormControl The React component docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gitstart @mui-bot @ZeeshanTamboli @zannager