Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][base] Move styles to the bottom of demos code #36498

Closed
13 tasks done
michaldudak opened this issue Mar 12, 2023 · 14 comments
Closed
13 tasks done

[docs][base] Move styles to the bottom of demos code #36498

michaldudak opened this issue Mar 12, 2023 · 14 comments
Assignees
Labels
docs Improvements or additions to the documentation package: base-ui Specific to @mui/base ready to take Help wanted. Guidance available. There is a high chance the change will be accepted umbrella For grouping multiple issues to provide a holistic view

Comments

@michaldudak
Copy link
Member

michaldudak commented Mar 12, 2023

The most important part of the demo - the actual component code should be as high in the file as possible. Currently, most of the demos have significantly large style definitions, which must be scrolled to get to the most important parts of the code.

@michaldudak michaldudak added docs Improvements or additions to the documentation package: base-ui Specific to @mui/base labels Mar 12, 2023
@github-project-automation github-project-automation bot moved this to To do 📃 in Base UI Mar 12, 2023
@gitstart
Copy link
Contributor

@michaldudak @gzrae I would like to work on this

@michaldudak
Copy link
Member Author

Go ahead! Please create separate PRs per component, so it's faster to check, and the progress is more visible.

@sai6855
Copy link
Contributor

sai6855 commented Mar 14, 2023

@gitstart even i want to work on this, before working can you list components you are working. so that we both don't end up working on same components.

@gitstart
Copy link
Contributor

@gitstart even i want to work on this, before working can you list components you are working. so that we both don't end up working on same components.

Hi @sai6855, I was actually planning on working on all the components, but you can feel free to choose the ones you want to work on so I can ignore them.

@sai6855
Copy link
Contributor

sai6855 commented Mar 14, 2023

Cool I'll work on, button, input, select, slider, switch, badge, snackbar. You can work on remaining components which are 11 in number.

@varunmulay22
Copy link
Contributor

@sai6855 @gitstart could you share your updates here so I can pick up some components which you both aren't? Thanks :)

@gitstart
Copy link
Contributor

@sai6855 @gitstart could you share your updates here so I can pick up some components which you both aren't? Thanks :)

I am currently rounding up my share of components and will be pushing my PRs soon, you can ask @sai6855 about the progress on his end.

@sai6855
Copy link
Contributor

sai6855 commented Mar 17, 2023

@sai6855 @gitstart could you share your updates here so I can pick up some components which you both aren't? Thanks :)

I am currently rounding up my share of components and will be pushing my PRs soon, you can ask @sai6855 about the progress on his end.

Same here, I'll create prs soon

@sai6855
Copy link
Contributor

sai6855 commented Mar 17, 2023

@varunmulay22 if you want, you can work on this issue
#35933

@varunmulay22
Copy link
Contributor

sure looking into it @sai6855

@varunmulay22
Copy link
Contributor

anything I can help here guys? please share the ones you haven't started. I don't see any PR's from your end yet hence asking

@gitstart
Copy link
Contributor

anything I can help here guys? please share the ones you haven't started. I don't see any PR's from your end yet hence asking

I've pushed a few PRs, the rest are coming soon.

@ZeeshanTamboli ZeeshanTamboli added umbrella For grouping multiple issues to provide a holistic view ready to take Help wanted. Guidance available. There is a high chance the change will be accepted labels Mar 31, 2023
@ZeeshanTamboli
Copy link
Member

ZeeshanTamboli commented Mar 31, 2023

I have made a list of the unstyled components and updated them with the respective PRs in the description. Feel free to take the remaining components.

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 10, 2023

The changes done with this issue make a lot of sense 👌.

A possible continuation on this issue: #38911. Instead of moving the source to the bottom, we could move them to a different tab.

@michaldudak michaldudak moved this from To do 📃 to Done 🎉 in Base UI Oct 25, 2023
@danilo-leal danilo-leal removed this from Joy UI Mar 5, 2024
@michaldudak michaldudak removed this from Base UI Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: base-ui Specific to @mui/base ready to take Help wanted. Guidance available. There is a high chance the change will be accepted umbrella For grouping multiple issues to provide a holistic view
Projects
None yet
Development

No branches or pull requests

6 participants