[docs-infra] Tweak feedback footer section design #36556
Conversation
danilo-leal
added
docs
Netlify deploy previewhttps://deploy-preview-36556--material-ui.netlify.app/ Bundle size report |
danilo-leal
requested review from
oliviertassinari,
siriwatknp,
mapache-salvaje and
gerdadesign
There was a problem hiding this comment.
There are a few additional tasks I haven't done yet in this PR due to... I don't know how + need help
For the translations, unless @mj12albert would like to take on an objective to go after the Chinese community, it's not needed.
For the dedicated roadmap, GitHub issues, changelog per projects, we don't have the infrastructure for it.
|
Great idea! And it looks really clean too! 👏 |
Co-authored-by: Sam Sycamore <[email protected]> Signed-off-by: Danilo Leal <[email protected]>
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
danilo-leal
changed the title
danilo-leal
requested review from
zanivan and
alexfauquette
and removed request for
gerdadesign
|
Reviving this PR with a slightly different approach than last time ⎯ I'm curious to see what you all think! |
|
I did not look at the initial proposal, but this one looks nice. The edit button at the top was a bit too easy to miss Did you consider to following reorder? such that what is about the current page is on top and navigation to other pages below
|
|
@alexfauquette This is a good suggestion! Just pushed it 😬 |
|
@oliviertassinari Any thoughts from you (maybe particularly about the "Edit this page" reposition) before merging it? |
| <IconButton | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| href="https://twitter.com/MUI_hq" |
There was a problem hiding this comment.
Should these be project or company links? projects might make more sense like on https://react.dev/learn
| href="https://twitter.com/MUI_hq" | |
| href="https://twitter.com/MaterialUI" |
I think I will be more likely to use a GitHub link here (the same one as in the header), more than the other link.
There was a problem hiding this comment.
I'll check if I can get this link to work dynamically (i.e., if you're visiting Joy UI's docs, it's Joy's Twitter account, etc.). Though that wouldn't work super well for products we may not have an account (not sure but maybe System?)
There was a problem hiding this comment.
I think I'll go with a simpler approach now — we can iterate later on if we want to have the Twitter link dynamic per product!
| title="Twitter" | ||
| size="small" | ||
| > | ||
| <TwitterIcon fontSize="small" sx={{ color: 'grey.500' }} /> |
There was a problem hiding this comment.
Likely for a different time & different PR, but
This current version of the PR is a simplified take on its original version. My main goal with it is better to use the documentation footer space in a non-intrusive way, potentially adding more traction to channels and links previously accessible through the website footer.
A new and notable change here is removing the "Edit this page" from the top of the page and adding it to the footer. I think we could clear that space up there and make it closer to other page-related actions (primarily the like/dislike). We may discuss if this impacts engagement with this "feature" ⎯ it's a common design pattern across multiple libraries, though, so I don't think there would be a gigantic discoverability impact.
👉 https://deploy-preview-36556--material-ui.netlify.app/joy-ui/react-button/
Overall changes