Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Improve footer links #39352

Open
2 of 3 tasks
oliviertassinari opened this issue Oct 8, 2023 · 1 comment
Open
2 of 3 tasks

[docs-infra] Improve footer links #39352

oliviertassinari opened this issue Oct 8, 2023 · 1 comment
Assignees
Labels
enhancement This is not a bug, nor a new feature scope: docs-infra Specific to the docs-infra product

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 8, 2023

Context 🔦

A continuation of #36556. I would propose these changes.

Steps to reproduce 🕹

Steps:

Open https://mui.com/material-ui/react-switch/#api

Current behavior 😯

Screenshot 2023-10-08 at 23 37 48

Expected behavior 🤔

Screenshot 2023-10-08 at 23 47 03
  • 1. I wouldn't expect to see "Careers". As far as we have tried to list job ads from the docs, the conversion rate was pretty bad. By the nature of our business model, people using Material UI are most likely to be on the opposite spectrum of who we need to hire (statistically speaking). Per https://docs.google.com/document/d/1Bj7f6xIufued0R-oxCsViguUoik8MwrDrCrrISWys58/edit where we see too many applications, I think making finding the roles harder is the way to go. [docs-infra] Simplify footer #39709
  • 2. Not link to LinkedIn. The docs is a space for developers, I think the goal is to make it feel as much as possible a pure open-source vibe, this link creates a commercial license vibe. [docs-infra] Simplify footer #39709
  • 3. The link to "Store" feels too broad. I think it would be more coherent to reference "Templates" that we have in the side nav.
    More broadly, I think we should push toward killing the noting of "Store". https://webflow.com/templates makes more sense to me, as for X, it should have its own space, and the same goes for our Figma kit.

Ideally, in the future:

Your environment 🌎

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.
@oliviertassinari oliviertassinari added status: waiting for maintainer These issues haven't been looked at yet by a maintainer scope: docs-infra Specific to the docs-infra product enhancement This is not a bug, nor a new feature and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 8, 2023
@danilo-leal
Copy link
Contributor

I'm ok with the first two points there. The third is the only one I'd be hesitant to do right now unless we invest slightly more engineering time to make it dynamic per product. That's because the footer is currently the same for the whole doc space, and linking the "Templates that we have in the side nav" is just a Material UI thing.

I think it'd be ok to keep the Store for now and later on do the enhancement there — what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature scope: docs-infra Specific to the docs-infra product
Projects
Status: Backlog
Development

No branches or pull requests

3 participants