-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] change CreateEmotionCache to use insertionPoint
#32104
[examples] change CreateEmotionCache to use insertionPoint
#32104
Conversation
insertionPoint
(#32068)insertionPoint
One thing is, It worked fine on ssr, nextjs, nextjs-with-typescript examples but not worked on remix-with-typescript example. |
Thanks for the contribution, will test it out and review it this week. I will also try to see why the remix example is not working. |
@mnajdova I took a look on it, but this bug(?) happens on master branch too (when disabled javascript on browser) |
It definitely should happen. Could be a regression from a recent PR. I will take a look at it next week. Thanks for catching it. If you inspect our docs, for example - https://mui.com/material-ui/react-floating-action-button/ with disabled JavaScript you will see that all styles are in the head, there are no inline |
@mnajdova I think this problem can be somewhat related to this issue..? |
Yes, could be, thanks for linking the issue. Let's wait for the stable nextjs release with the fix and test out again :) |
Let's wait for the next version that contains the fix in vercel/next.js#36675 (comment) to be stable so that we can test the changes reliably. |
@mnajdova Tested with Next.js 12.2.0. And I can see that this <style/> tag regression is not happening anymore! |
Just FYI, it's on my list for today :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for the patience :)
insertionPoint
insertionPoint
Close #32068