Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Change Next.js example's createEmotionCache from using 'prepend' to using 'insertionPoint' #32068

Closed
2 tasks done
ANTARES-KOR opened this issue Mar 31, 2022 · 3 comments · Fixed by #32104
Closed
2 tasks done

[examples] Change Next.js example's createEmotionCache from using 'prepend' to using 'insertionPoint' #32068

ANTARES-KOR opened this issue Mar 31, 2022 · 3 comments · Fixed by #32104
Labels
good first issue Great for first contributions. Enable to learn the contribution process. new feature New feature or request

Comments

@ANTARES-KOR
Copy link
Contributor

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

Emotion-js added a new feature 'insertionPoint' to createCache in this pull request and marked previous 'prepend' option as deprecated.

But Mui's next.js example uses prepend. You can find It here

Examples 🌈

No response

Motivation 🔦

I tried to change this to using insertionPoint myself. But due to my lack of ability, I found it really tricky to do it on SSR.
So It would be a lot of help if Mui team can give a best example on this one.
or If there's any guide you can provide, I'll be very happy to contribute.
@ANTARES-KOR ANTARES-KOR added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Mar 31, 2022
@ANTARES-KOR ANTARES-KOR changed the title Change Next.js example's createEmotionCache from using 'prepend' to using 'insertionPoint' [examples] Change Next.js example's createEmotionCache from using 'prepend' to using 'insertionPoint' Mar 31, 2022
@siriwatknp siriwatknp added good first issue Great for first contributions. Enable to learn the contribution process. new feature New feature or request and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Apr 1, 2022
@mnajdova
Copy link
Member

mnajdova commented Apr 1, 2022

I can help implement this if someone is interested in creating a PR.

@ANTARES-KOR
Copy link
Contributor Author

Okay, I'll assign myself on this one

@ANTARES-KOR
Copy link
Contributor Author

#32104

I made a PR on this issue!

@ZeeshanTamboli ZeeshanTamboli mentioned this issue Apr 4, 2022
Merged
1 task
@geraldaddey geraldaddey mentioned this issue Jun 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Great for first contributions. Enable to learn the contribution process. new feature New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@mnajdova @siriwatknp @ANTARES-KOR