-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Hide scrollbars of hero containers #29474
Conversation
Looks like a regression from #29141 to fix #29119. I find it weird that we can scroll the right side on https://mui.com/. |
oh I see. Yeah I didn't have enough time to find where it's coming from, so just added the overflow:hidden I don't know why you'd want the templates hero to be scrollable though 🤔 It already "scrolls" automatically through the animation... Homepage makes more sense |
I can reproduce the same issue on https://deploy-preview-29474--material-ui.netlify.app/design-kits/. On https://deploy-preview-29474--material-ui.netlify.app/x/, there are 3 different scroll containers, it's weird @hbjORbj Do you want to lead the fix since you started in #29141? Speaking of scrollbar for macOS maintainers, I would recommend to always be using: as it matches what Windows end-users (what the large majority of people use) experience. |
Yes, I'm not super familiar with the various sections of the site and the goals laid out for each. What I would've done would be to make them ALL non-scrollable & ONLY update the 1 or 2 pages that actually need to be scrollable |
with that option selected I still see the extra scrollbar |
@oliviertassinari Yep, I will make a fix for this after I address some other priorities! |
1332da7
to
a89eb56
Compare
I've summarised the final results below:
Preview: https://deploy-preview-29474--material-ui.netlify.app |
@hbjORbj Maybe /core and /x need to be scrollable as well? |
@danilo-leal Sure, I made Currently, the heroes on
|
I think I'd standardize it, have |
I'll merge this one since it has been open for quite a while and /, /core and/x heroes are now scrollable. Must admit though that I kinda feel the same as Olivier - these heroes being scrollable is kinda weird, it just doesn't seem very polished to me. I think we can iterate in future PRs for ways to make this interaction more elegant. |
for some reason there's a scrollbar showing up inside of this animated perspective box. This PR should remove that
https://mui.com/templates/