Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Make the showcase component of hero on landing page scrollable #29119

Closed
2 tasks done
LorenzHenk opened this issue Oct 17, 2021 · 10 comments · Fixed by #29141
Closed
2 tasks done

[website] Make the showcase component of hero on landing page scrollable #29119

LorenzHenk opened this issue Oct 17, 2021 · 10 comments · Fixed by #29141
Labels
out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) website Pages that are not documentation-related, marketing-focused.

Comments

@LorenzHenk
Copy link

The top right section of the landing page is cut off and cannot be scrolled, making it impossible to see some of the cool examples.

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

The height is based on the screen height (calc(100vh - 120px)). Overflowing content is hidden.

Note that e.g. the "Use the sx prop to add these properties" example is not fully visible.

image

Expected Behavior 🤔

IMO the best way to handle this is by making the section scrollable.

Steps to Reproduce 🕹

Steps:

  1. Go to https://mui.com/

Context 🔦

I noticed that the "Use the sx prop to add these properties" example was cut off.

Your Environment 🌎

24" screen in landscape orientation 😄

@LorenzHenk LorenzHenk added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 17, 2021
@hbjORbj hbjORbj added bug 🐛 Something doesn't work website Pages that are not documentation-related, marketing-focused. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 18, 2021
@hbjORbj
Copy link
Member

hbjORbj commented Oct 18, 2021

@LorenzHenk Thanks for the report. Yes, I agree that you can make the box scrollable. I suggest the following. Would you like to create a PR for this?

diff --git a/docs/src/components/home/Hero.tsx b/docs/src/components/home/Hero.tsx
index c1dfb40a4a..f2107c2592 100644
--- a/docs/src/components/home/Hero.tsx
+++ b/docs/src/components/home/Hero.tsx
@@ -123,6 +123,7 @@ export default function Hero() {
       rightSx={{
         p: 3,
         minWidth: 2000,
+        overflowY: 'auto',
         '& > div': {
           width: 360,
           display: 'inline-flex',

@hbjORbj hbjORbj added the good first issue Great for first contributions. Enable to learn the contribution process. label Oct 18, 2021
@hbjORbj hbjORbj changed the title [website] Landing page top examples cut off [website] Make the showcase component of hero on landing page scrollable Oct 18, 2021
@ysstudio22
Copy link

Hi @hbjORbj

I'm Yoshi. I'm interested in contributing if this issue hasn't been assigned yet. I'll wait until @LorenzHenk has replied to you. Thanks🙂

@LorenzHenk
Copy link
Author

Hey @hbjORbj!
Thanks, I would have liked to implement this, but it seems like someone was already faster (#29141) 😁

@mbrookes
Copy link
Member

Should we change it here too?

@ysstudio22
Copy link

@LorenzHenk I didn't mean to take it from you. It's your idea. 👍🏻

@siriwatknp
Copy link
Member

cc @danilo-leal (At first I was thinking about parallax that section when scrolling down but no time to do it)

@mbrookes
Copy link
Member

mbrookes commented Nov 1, 2021

@hbjORbj : #29119 (comment) ?

@hbjORbj
Copy link
Member

hbjORbj commented Nov 1, 2021

@mbrookes This was addressed in #29141. Check out #29141 (comment) :)

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 2, 2021

The top right section of the landing page is cut off and cannot be scrolled, making it impossible to see some of the cool examples.

Do we really want to fix this? I wouldn't, it introduced a regression: I can't see the scrollbar on https://mui.com/, and yet, when I try to scroll down the page (my cursor happens to be on the wrong side of the page), I can't. It's the hero container that scrolls.

@LorenzHenk
Copy link
Author

LorenzHenk commented Nov 2, 2021

You're right, after scrolling to the bottom of the hero section I need to stop scrolling for a second or move my cursor a bit and only after that scrolling affects the whole page. Tested with Firefox and Chrome.

2021-11-02.20-21-01.mp4

Do you have an alternative idea on how this could be handled? It'd still be a shame to not be able to view all the demos 😁

@oliviertassinari oliviertassinari added out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) and removed bug 🐛 Something doesn't work good first issue Great for first contributions. Enable to learn the contribution process. labels May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants