-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Make the showcase component of hero on landing page scrollable #29119
Comments
@LorenzHenk Thanks for the report. Yes, I agree that you can make the box scrollable. I suggest the following. Would you like to create a PR for this? diff --git a/docs/src/components/home/Hero.tsx b/docs/src/components/home/Hero.tsx
index c1dfb40a4a..f2107c2592 100644
--- a/docs/src/components/home/Hero.tsx
+++ b/docs/src/components/home/Hero.tsx
@@ -123,6 +123,7 @@ export default function Hero() {
rightSx={{
p: 3,
minWidth: 2000,
+ overflowY: 'auto',
'& > div': {
width: 360,
display: 'inline-flex', |
Hi @hbjORbj I'm Yoshi. I'm interested in contributing if this issue hasn't been assigned yet. I'll wait until @LorenzHenk has replied to you. Thanks🙂 |
Should we change it here too? |
@LorenzHenk I didn't mean to take it from you. It's your idea. 👍🏻 |
cc @danilo-leal (At first I was thinking about parallax that section when scrolling down but no time to do it) |
@mbrookes This was addressed in #29141. Check out #29141 (comment) :) |
Do we really want to fix this? I wouldn't, it introduced a regression: I can't see the scrollbar on https://mui.com/, and yet, when I try to scroll down the page (my cursor happens to be on the wrong side of the page), I can't. It's the hero container that scrolls. |
You're right, after scrolling to the bottom of the hero section I need to stop scrolling for a second or move my cursor a bit and only after that scrolling affects the whole page. Tested with Firefox and Chrome. 2021-11-02.20-21-01.mp4Do you have an alternative idea on how this could be handled? It'd still be a shame to not be able to view all the demos 😁 |
The top right section of the landing page is cut off and cannot be scrolled, making it impossible to see some of the cool examples.
Current Behavior 😯
The
height
is based on the screen height (calc(100vh - 120px)
). Overflowing content is hidden.Note that e.g. the "Use the sx prop to add these properties" example is not fully visible.
Expected Behavior 🤔
IMO the best way to handle this is by making the section scrollable.
Steps to Reproduce 🕹
Steps:
Context 🔦
I noticed that the "Use the sx prop to add these properties" example was cut off.
Your Environment 🌎
24" screen in landscape orientation 😄
The text was updated successfully, but these errors were encountered: