Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix TextField demo layout #26710

Merged
merged 4 commits into from
Jun 15, 2021
Merged

[docs] Fix TextField demo layout #26710

merged 4 commits into from
Jun 15, 2021

Conversation

vicasas
Copy link
Member

@vicasas vicasas commented Jun 12, 2021 •
edited by oliviertassinari
Loading

@vicasas vicasas added the docs Improvements or additions to the documentation label Jun 12, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Jun 12, 2021 •
edited
Loading

No bundle size changes (experimental)

Generated by 🚫 dangerJS against 0a06bc2

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 12, 2021 •
edited
Loading

I would propose we significantly simplify the demo.
We can start by only rendering the default variant of the TextField. The other ones adds nothing for the developers (maybe a bit for maintainers as a visual regression test, but adding margin is soo generic that I doubt we need to care).

@vicasas
Copy link
Member Author

vicasas commented Jun 13, 2021

@oliviertassinari Should we apply the same for similar demos of text field and keep only the default variant?

@oliviertassinari
Copy link
Member

Should we apply the same for similar demos of text field and keep only the default variant?

I'm not sure. The reason why I proposed it here is because the outer margin is invariant to the style of the inner element.

@siriwatknp
Copy link
Member

I added fullWidth demo to preserve the info from the previous version.

@siriwatknp siriwatknp merged commit 7dda433 into mui:next Jun 15, 2021
@vicasas vicasas deleted the feature/layout-textfield branch June 15, 2021 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TextField] Documentation Layout section mentions the property margin which is overwritten by an sx style
4 participants
@vicasas @mui-pr-bot @oliviertassinari @siriwatknp