[TextField] Documentation Layout section mentions the property margin which is overwritten by an sx style

[italodeandra]

This sections https://github.com/mui-org/material-ui/blob/next/docs/src/pages/components/text-fields/text-fields.md#layout has the following sentence:

margin prop can be used to alter the vertical spacing of inputs. Using none (default) will not apply margins to the FormControl, whereas dense and normal will. dense and normal alter other styles to meet the specification.

The code indeed uses this property

https://github.com/mui-org/material-ui/blob/cf2f6fa90608b109978698fc48120920beaaa51f/docs/src/pages/components/text-fields/LayoutTextFields.tsx#L39

But it is overwritten by this sx style

https://github.com/mui-org/material-ui/blob/cf2f6fa90608b109978698fc48120920beaaa51f/docs/src/pages/components/text-fields/LayoutTextFields.tsx#L13

So everything has the same margin as you can see here

https://next.material-ui.com/components/text-fields/#layout

[vicasas]

@italodeandra Thanks for reporting this. I have been reviewing this problem quite a bit since there seems to be or will be a confusion with the margin and dense props.

In v4 size modifies the size of the input while dense modifies the vertical spacing and also the size.

In v5 size modifies the size of the input while dense modifies only the vertical spacing and NOT the size.

Luckily in the migration guide https://next.material-ui.com/guides/migration-v4/#textfield this was already noticed but what about the developers who used dense for both purposes? (size and spacing) should they use size and margin at the same time? cc: @oliviertassinari @mnajdova

I will send a PR to correct the example of the documentation of the layout section.

[oliviertassinari]

should they use size and margin at the same time?

Yes