Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint] Start enforcing react/prop-types #2360

Merged
merged 1 commit into from
Dec 3, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/app-bar.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ const AppBar = React.createClass({
},

propTypes: {
children: React.PropTypes.node,
className: React.PropTypes.string,
iconClassNameLeft: React.PropTypes.string,
iconClassNameRight: React.PropTypes.string,
iconElementLeft: React.PropTypes.element,
Expand Down
4 changes: 4 additions & 0 deletions src/app-canvas.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ const AppCanvas = React.createClass({
muiTheme: React.PropTypes.object,
},

propTypes: {
children: React.PropTypes.node,
},

//for passing default theme context to children
childContextTypes: {
muiTheme: React.PropTypes.object,
Expand Down
1 change: 1 addition & 0 deletions src/auto-complete.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ const AutoComplete = React.createClass({
open: React.PropTypes.bool,
searchText: React.PropTypes.string,
showAllItems: React.PropTypes.bool,
style: React.PropTypes.object,
touchTapCloseDelay: React.PropTypes.number,
updateWhenFocused: React.PropTypes.bool,
},
Expand Down
1 change: 1 addition & 0 deletions src/avatar.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ const Avatar = React.createClass({

propTypes: {
backgroundColor: React.PropTypes.string,
children: React.PropTypes.node,
color: React.PropTypes.string,
icon: React.PropTypes.element,
size: React.PropTypes.number,
Expand Down
1 change: 1 addition & 0 deletions src/badge.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export default React.createClass({
propTypes: {
badgeContent: React.PropTypes.node.isRequired,
badgeStyle: React.PropTypes.object,
children: React.PropTypes.node,
className: React.PropTypes.string,
primary: React.PropTypes.bool,
secondary: React.PropTypes.bool,
Expand Down
1 change: 1 addition & 0 deletions src/before-after-wrapper.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ const BeforeAfterWrapper = React.createClass({
afterStyle: React.PropTypes.object,
beforeElementType: React.PropTypes.string,
beforeStyle: React.PropTypes.object,
children: React.PropTypes.node,
elementType: React.PropTypes.string,
style: React.PropTypes.object,
},
Expand Down
7 changes: 5 additions & 2 deletions src/card/card.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,17 @@ import StylePropable from '../mixins/style-propable';
import CardExpandable from './card-expandable';

const Card = React.createClass({
mixins:[StylePropable],
mixins: [StylePropable],

getInitialState() {
return {expanded: this.props.initiallyExpanded ? true : false};
return {
expanded: this.props.initiallyExpanded ? true : false,
};
},

propTypes: {
actAsExpander: React.PropTypes.bool,
children: React.PropTypes.node,
expandable: React.PropTypes.bool,
initiallyExpanded: React.PropTypes.bool,
onExpandChange: React.PropTypes.func,
Expand Down
1 change: 1 addition & 0 deletions src/checkbox.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ const Checkbox = React.createClass({
labelStyle: React.PropTypes.object,
onCheck: React.PropTypes.func,
unCheckedIcon: React.PropTypes.element,
valueLink: React.PropTypes.object,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make this property deprecated since it's going to be the case in the next release of react.
We can use something like https://github.com/react-bootstrap/react-prop-types#deprecatedproptype-explanation

},

getInitialState() {
Expand Down
1 change: 1 addition & 0 deletions src/clearfix.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ const ClearFix = React.createClass({
},

propTypes: {
children: React.PropTypes.node,
style: React.PropTypes.object,
},

Expand Down
9 changes: 8 additions & 1 deletion src/dialog.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ import ReactTransitionGroup from 'react-addons-transition-group';
const TransitionItem = React.createClass({
mixins: [StylePropable],

propTypes: {
children: React.PropTypes.node,
style: React.PropTypes.object,
},

contextTypes: {
muiTheme: React.PropTypes.object,
},
Expand Down Expand Up @@ -79,11 +84,12 @@ const TransitionItem = React.createClass({
render() {
let {
style,
children,
...other,
} = this.props;

return <div {...other} style={this.prepareStyles(this.state.style, style)}>
{this.props.children}
{children}
</div>;
},
});
Expand Down Expand Up @@ -113,6 +119,7 @@ const DialogInline = React.createClass({
autoDetectWindowHeight: React.PropTypes.bool,
autoScrollBodyContent: React.PropTypes.bool,
bodyStyle: React.PropTypes.object,
children: React.PropTypes.node,
contentClassName: React.PropTypes.string,
contentStyle: React.PropTypes.object,
modal: React.PropTypes.bool,
Expand Down
1 change: 1 addition & 0 deletions src/drop-down-icon.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ const DropDownIcon = React.createClass({
},

propTypes: {
children: React.PropTypes.node,
closeOnMenuItemTouchTap: React.PropTypes.bool,
iconClassName: React.PropTypes.string,
iconLigature: React.PropTypes.string,
Expand Down
1 change: 1 addition & 0 deletions src/drop-down-menu.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ const DropDownMenu = React.createClass({
style: React.PropTypes.object,
underlineStyle:React.PropTypes.object,
value: React.PropTypes.any,
valueLink: React.PropTypes.object,
valueMember: React.PropTypes.string,
},

Expand Down
2 changes: 2 additions & 0 deletions src/enhanced-button.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ const EnhancedButton = React.createClass({

propTypes: {
centerRipple: React.PropTypes.bool,
children: React.PropTypes.node,
containerElement: React.PropTypes.oneOfType([
React.PropTypes.string,
React.PropTypes.element,
Expand All @@ -83,6 +84,7 @@ const EnhancedButton = React.createClass({
tabIndex: React.PropTypes.number,
touchRippleColor: React.PropTypes.string,
touchRippleOpacity: React.PropTypes.number,
type: React.PropTypes.string,
},

getDefaultProps() {
Expand Down
5 changes: 3 additions & 2 deletions src/enhanced-switch.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ const EnhancedSwitch = React.createClass({
},

propTypes: {
className: React.PropTypes.string,
defaultSwitched: React.PropTypes.bool,
disableFocusRipple: React.PropTypes.bool,
disableTouchRipple: React.PropTypes.bool,
Expand All @@ -43,6 +44,7 @@ const EnhancedSwitch = React.createClass({
labelPosition: React.PropTypes.oneOf(['left', 'right']),
labelStyle: React.PropTypes.object,
name: React.PropTypes.string,
onFocus: React.PropTypes.func,
onParentShouldUpdate: React.PropTypes.func.isRequired,
onSwitch: React.PropTypes.func,
required: React.PropTypes.bool,
Expand Down Expand Up @@ -188,7 +190,6 @@ const EnhancedSwitch = React.createClass({

render() {
let {
type,
name,
value,
label,
Expand Down Expand Up @@ -227,7 +228,7 @@ const EnhancedSwitch = React.createClass({
</label>
) : null;

let inputProps = {
const inputProps = {
ref: 'checkbox',
type: this.props.inputType,
style: this.prepareStyles(styles.input),
Expand Down
1 change: 1 addition & 0 deletions src/menus/menu-item.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ const MenuItem = React.createClass({

propTypes: {
checked: React.PropTypes.bool,
children: React.PropTypes.node,
desktop: React.PropTypes.bool,
disabled: React.PropTypes.bool,
focusState: React.PropTypes.oneOf([
Expand Down
1 change: 1 addition & 0 deletions src/menus/menu.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ const Menu = React.createClass({
propTypes: {
animated: React.PropTypes.bool,
autoWidth: React.PropTypes.bool,
children: React.PropTypes.node,
desktop: React.PropTypes.bool,
initiallyKeyboardFocused: React.PropTypes.bool,
listStyle: React.PropTypes.object,
Expand Down
1 change: 1 addition & 0 deletions src/ripples/touch-ripple.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const TouchRipple = React.createClass({

propTypes: {
centerRipple: React.PropTypes.bool,
children: React.PropTypes.node,
color: React.PropTypes.string,
opacity: React.PropTypes.number,
style: React.PropTypes.object,
Expand Down
2 changes: 2 additions & 0 deletions src/select-field.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,12 @@ const SelectField = React.createClass({

propTypes: {
autoWidth: React.PropTypes.bool,
disabled: React.PropTypes.bool,
errorStyle: React.PropTypes.object,
errorText: React.PropTypes.node,
floatingLabelStyle: React.PropTypes.object,
floatingLabelText: React.PropTypes.node,
fullWidth: React.PropTypes.bool,
hintText: React.PropTypes.node,
iconStyle: React.PropTypes.object,
id: React.PropTypes.string,
Expand Down
2 changes: 2 additions & 0 deletions src/table/table-row.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ const TableRow = React.createClass({
},

propTypes: {
children: React.PropTypes.node,
className: React.PropTypes.string,
displayBorder: React.PropTypes.bool,
hoverable: React.PropTypes.bool,
onCellClick: React.PropTypes.func,
Expand Down
2 changes: 2 additions & 0 deletions src/table/table.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ const Table = React.createClass({
propTypes: {
allRowsSelected: React.PropTypes.bool,
bodyStyle: React.PropTypes.object,
children: React.PropTypes.node,
className: React.PropTypes.string,
fixedFooter: React.PropTypes.bool,
fixedHeader: React.PropTypes.bool,
footerStyle: React.PropTypes.object,
Expand Down
17 changes: 10 additions & 7 deletions src/tabs/tabTemplate.jsx
Original file line number Diff line number Diff line change
@@ -1,15 +1,18 @@
import React from 'react';


const TabTemplate = React.createClass({
propTypes: {
children: React.PropTypes.node,
selected: React.PropTypes.bool,
},

render() {
let styles = {
'height': 0,
'overflow': 'hidden',
'width': '100%',
'position': 'relative',
'textAlign': 'initial',
const styles = {
height: 0,
overflow: 'hidden',
width: '100%',
position: 'relative',
textAlign: 'initial',
};

if (this.props.selected) {
Expand Down
2 changes: 1 addition & 1 deletion src/tabs/tabs.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ const Tabs = React.createClass({
},

propTypes: {
children: React.PropTypes.node,
contentContainerStyle: React.PropTypes.object,
initialSelectedIndex: React.PropTypes.number,
inkBarStyle: React.PropTypes.object,
Expand Down Expand Up @@ -86,7 +87,6 @@ const Tabs = React.createClass({
initialSelectedIndex,
inkBarStyle,
style,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dead property

tabWidth,
tabItemContainerStyle,
tabTemplate,
...other,
Expand Down
1 change: 1 addition & 0 deletions src/time-picker/clock-pointer.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const ClockPointer = React.createClass({
},

propTypes: {
hasSelected: React.PropTypes.bool,
type: React.PropTypes.oneOf(['hour', 'minute']),
value: React.PropTypes.number,
},
Expand Down
2 changes: 2 additions & 0 deletions src/time-picker/time-display.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ const TimeDisplay = React.createClass({
affix: React.PropTypes.oneOf(['', 'pm', 'am']),
format: React.PropTypes.oneOf(['ampm', '24hr']),
mode: React.PropTypes.oneOf(['hour', 'minute']),
onSelectHour: React.PropTypes.func,
onSelectMin: React.PropTypes.func,
selectedTime: React.PropTypes.object.isRequired,
},

Expand Down
1 change: 1 addition & 0 deletions src/time-picker/time-picker-dialog.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ const TimePickerDialog = React.createClass({

propTypes: {
autoOk: React.PropTypes.bool,
format: React.PropTypes.oneOf(['ampm', '24hr']),
initialTime: React.PropTypes.object,
onAccept: React.PropTypes.func,
onDismiss: React.PropTypes.func,
Expand Down
1 change: 1 addition & 0 deletions src/toolbar/toolbar-group.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ const ToolbarGroup = React.createClass({
},

propTypes: {
children: React.PropTypes.node,
className: React.PropTypes.string,
firstChild: React.PropTypes.bool,
float: React.PropTypes.string,
Expand Down
1 change: 1 addition & 0 deletions src/toolbar/toolbar.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const Toolbar = React.createClass({
},

propTypes: {
children: React.PropTypes.node,
className: React.PropTypes.string,
noGutter: React.PropTypes.bool,
style: React.PropTypes.object,
Expand Down
1 change: 1 addition & 0 deletions src/transition-groups/scale-in-child.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ const ScaleInChild = React.createClass({
},

propTypes: {
children: React.PropTypes.node,
enterDelay: React.PropTypes.number,
maxScale: React.PropTypes.number,
minScale: React.PropTypes.number,
Expand Down
1 change: 1 addition & 0 deletions src/transition-groups/scale-in.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ const ScaleIn = React.createClass({

propTypes: {
childStyle: React.PropTypes.object,
children: React.PropTypes.node,
enterDelay: React.PropTypes.number,
maxScale: React.PropTypes.number,
minScale: React.PropTypes.number,
Expand Down
2 changes: 2 additions & 0 deletions src/transition-groups/slide-in-child.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ const SlideInChild = React.createClass({
},

propTypes: {
children: React.PropTypes.node,
direction: React.PropTypes.string,
enterDelay: React.PropTypes.number,
//This callback is needed bacause
//the direction could change when leaving the dom
Expand Down
1 change: 1 addition & 0 deletions src/transition-groups/slide-in.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ const SlideIn = React.createClass({

propTypes: {
childStyle: React.PropTypes.object,
children: React.PropTypes.node,
direction: React.PropTypes.oneOf(['left', 'right', 'up', 'down']),
enterDelay: React.PropTypes.number,
style: React.PropTypes.object,
Expand Down