[eslint] Start enforcing react/prop-types #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,6 +37,7 @@ const Checkbox = React.createClass({ | |||
| labelStyle: React.PropTypes.object, | |||
| onCheck: React.PropTypes.func, | |||
| unCheckedIcon: React.PropTypes.element, | |||
| valueLink: React.PropTypes.object, | |||
There was a problem hiding this comment.
We should make this property deprecated since it's going to be the case in the next release of react.
We can use something like https://github.com/react-bootstrap/react-prop-types#deprecatedproptype-explanation
oliviertassinari
added a commit
that referenced
this pull request
Dec 3, 2015
[eslint] Start enforcing react/prop-types
zannager
added
package: system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's just half of the work that need to be done.