Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Supress 404 img warnings in browser tests #23106

Merged
merged 3 commits into from
Oct 16, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions packages/material-ui-lab/src/AvatarGroup/AvatarGroup.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ describe('<AvatarGroup />', () => {
it('should display all the avatars', () => {
const { container } = render(
<AvatarGroup max={3}>
<Avatar src="image-url" />
<Avatar src="image-url" />
<Avatar src="image-url" />
<Avatar src="/fake.png" />
<Avatar src="/fake.png" />
<Avatar src="/fake.png" />
</AvatarGroup>,
);
expect(container.querySelectorAll('.MuiAvatar-root').length).to.equal(3);
Expand All @@ -37,10 +37,10 @@ describe('<AvatarGroup />', () => {
it('should display 2 avatars and "+2"', () => {
const { container } = render(
<AvatarGroup max={3}>
<Avatar src="image-url" />
<Avatar src="image-url" />
<Avatar src="image-url" />
<Avatar src="image-url" />
<Avatar src="/fake.png" />
<Avatar src="/fake.png" />
<Avatar src="/fake.png" />
<Avatar src="/fake.png" />
</AvatarGroup>,
);
expect(container.querySelectorAll('.MuiAvatar-root').length).to.equal(3);
Expand All @@ -51,7 +51,7 @@ describe('<AvatarGroup />', () => {
it('should display all avatars with default (circular) variant', () => {
const { container } = render(
<AvatarGroup>
<Avatar src="image-url" />
<Avatar src="/fake.png" />
</AvatarGroup>,
);
const avatarGroup = container.firstChild;
Expand All @@ -67,7 +67,7 @@ describe('<AvatarGroup />', () => {
it('should display all avatars with the specified variant', () => {
const { container } = render(
<AvatarGroup variant="square">
<Avatar src="image-url" />
<Avatar src="/fake.png" />
</AvatarGroup>,
);
const avatarGroup = container.firstChild;
Expand All @@ -83,7 +83,7 @@ describe('<AvatarGroup />', () => {
it("should respect child's avatar variant prop if specified", () => {
const { container } = render(
<AvatarGroup variant="square">
<Avatar src="image-url" variant="rounded" />
<Avatar src="/fake.png" variant="rounded" />
</AvatarGroup>,
);
const avatarGroup = container.firstChild;
Expand Down
10 changes: 5 additions & 5 deletions packages/material-ui/src/Avatar/Avatar.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ describe('<Avatar />', () => {
const { container } = render(
<Avatar
className="my-avatar"
src="something.jpg"
src="/fake.png"
alt="Hello World!"
data-my-prop="woofAvatar"
/>,
Expand All @@ -48,12 +48,12 @@ describe('<Avatar />', () => {
expect(avatar).to.not.have.class(classes.colorDefault);
expect(img).to.have.class(classes.img);
expect(img).to.have.attribute('alt', 'Hello World!');
expect(img).to.have.attribute('src', 'something.jpg');
expect(img).to.have.attribute('src', '/fake.png');
});

it('should be able to add more props to the image', () => {
const onError = spy();
const { container } = render(<Avatar src="something.jpg" imgProps={{ onError }} />);
const { container } = render(<Avatar src="/fake.png" imgProps={{ onError }} />);
const img = container.querySelector('img');
fireEvent.error(img);
expect(onError.callCount).to.equal(1);
Expand All @@ -62,7 +62,7 @@ describe('<Avatar />', () => {

describe('image avatar with unrendered children', () => {
it('should render a div containing an img, not children', () => {
const { container } = render(<Avatar src="something.jpg">MB</Avatar>);
const { container } = render(<Avatar src="/fake.png">MB</Avatar>);
const avatar = container.firstChild;
const imgs = container.querySelectorAll('img');
expect(imgs.length).to.equal(1);
Expand All @@ -71,7 +71,7 @@ describe('<Avatar />', () => {

it('should be able to add more props to the image', () => {
const onError = spy();
const { container } = render(<Avatar src="something.jpg" imgProps={{ onError }} />);
const { container } = render(<Avatar src="/fake.png" imgProps={{ onError }} />);
const img = container.querySelector('img');
fireEvent.error(img);
expect(onError.callCount).to.equal(1);
Expand Down
28 changes: 14 additions & 14 deletions packages/material-ui/src/CardMedia/CardMedia.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ describe('<CardMedia />', () => {
let classes;
const render = createClientRender();
before(() => {
classes = getClasses(<CardMedia image="/foo.jpg" />);
classes = getClasses(<CardMedia image="/fake.png" />);
});

describeConformance(<CardMedia image="/foo.jpg" />, () => ({
describeConformance(<CardMedia image="/fake.png" />, () => ({
classes,
inheritComponent: 'div',
mount,
Expand All @@ -21,52 +21,52 @@ describe('<CardMedia />', () => {
}));

it('should have the backgroundImage specified', () => {
const { container } = render(<CardMedia image="/foo.jpg" />);
const { container } = render(<CardMedia image="/fake.png" />);
const cardMedia = container.firstChild;
expect(cardMedia.style.backgroundImage).to.match(/\/foo\.jpg/m);
expect(cardMedia.style.backgroundImage).to.match(/\/fake.png/m);
});

it('should have backgroundImage specified even though custom styles got passed', () => {
const { container } = render(<CardMedia image="/foo.jpg" style={{ height: 200 }} />);
const { container } = render(<CardMedia image="/fake.png" style={{ height: 200 }} />);
const cardMedia = container.firstChild;
expect(cardMedia.style.backgroundImage).to.match(/\/foo\.jpg/m);
expect(cardMedia.style.backgroundImage).to.match(/\/fake.png/m);
expect(cardMedia.style.height).to.equal('200px');
});

it('should be possible to overwrite backgroundImage via custom styles', () => {
const { container } = render(
<CardMedia image="/foo.jpg" style={{ backgroundImage: 'url(/bar.jpg)' }} />,
<CardMedia image="/fake.png" style={{ backgroundImage: 'url(fake2.png)' }} />,
);
const cardMedia = container.firstChild;
expect(cardMedia.style.backgroundImage).to.match(/\/bar\.jpg/m);
expect(cardMedia.style.backgroundImage).to.match(/fake2.png/m);
});

describe('prop: component', () => {
it('should have `src` prop when media component specified', () => {
const { container } = render(<CardMedia image="/foo.jpg" component="iframe" />);
const { container } = render(<CardMedia image="/fake.png" component="iframe" />);
const cardMedia = container.firstChild;
expect(cardMedia).to.have.attribute('src', '/foo.jpg');
expect(cardMedia).to.have.attribute('src', '/fake.png');
});

it('should not have `src` prop when picture media component specified', () => {
const { container } = render(
<CardMedia component="picture">
<source media="(min-width: 600px)" srcSet="big-cat.jpg" />
<img src="cat.jpg" alt="hello" />
<source media="(min-width: 600px)" srcSet="/fake.png" />
<img src="/fake.png" alt="hello" />
</CardMedia>,
);
const cardMedia = container.firstChild;
expect(cardMedia).to.not.have.attribute('src');
});

it('should not have default inline style when media component specified', () => {
const { container } = render(<CardMedia src="/foo.jpg" component="picture" />);
const { container } = render(<CardMedia src="/fake.png" component="picture" />);
const cardMedia = container.firstChild;
expect(cardMedia.style.backgroundImage).to.equal('');
});

it('should not have `src` prop if not media component specified', () => {
const { container } = render(<CardMedia image="/foo.jpg" component="table" />);
const { container } = render(<CardMedia image="/fake.png" component="table" />);
const cardMedia = container.firstChild;
expect(cardMedia).to.not.have.attribute('src');
});
Expand Down
6 changes: 3 additions & 3 deletions packages/material-ui/src/ImageList/ImageList.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ import ImageList from './ImageList';

const itemsData = [
{
img: 'images/image-list/00-52-29-429_640.jpg',
img: '/fake.png',
title: 'Breakfast',
author: 'jill111',
},
{
img: 'images/image-list/burger-827309_640.jpg',
img: '/fake.png',
title: 'Tasty burger',
author: 'director90',
},
Expand Down Expand Up @@ -40,7 +40,7 @@ describe('<ImageList />', () => {

const children = itemsData.map((item) => (
<span
key={item.img}
key={item.title}
title={item.title}
subtitle={<span>by: {item.author}</span>}
data-testid="test-children"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ describe('<ImageListItem />', () => {
}));

const itemData = {
img: 'images/image-list/breakfast.jpg',
img: '/fake.png',
title: 'Breakfast',
author: 'jill111',
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ describe('<ImageListItemBar />', () => {
}));

const itemData = {
img: 'images/image-list/00-52-29-429_640.jpg',
img: '/fake.png',
title: 'Breakfast',
author: 'jill111',
};
Expand Down
Empty file added test/assets/fake.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Empty file added test/assets/fake2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 10 additions & 0 deletions test/karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,12 @@ module.exports = function setKarmaConfig(config) {
served: true,
included: true,
},
{
pattern: 'test/assets/*.png',
watched: false,
included: false,
served: true,
},
],
plugins: ['karma-mocha', 'karma-chrome-launcher', 'karma-sourcemap-loader', 'karma-webpack'],
/**
Expand All @@ -40,6 +46,10 @@ module.exports = function setKarmaConfig(config) {
preprocessors: {
'test/karma.tests.js': ['webpack', 'sourcemap'],
},
proxies: {
'/fake.png': '/base/test/assets/fake.png',
'/fake2.png': '/base/test/assets/fake2.png',
},
reporters: ['dots'],
webpack: {
mode: 'development',
Expand Down