[test] Supress 404 img warnings in browser tests #23106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
force-pushed
the
test/karma-img-404
branch
from
16c21dd to
583caf2
Compare
|
No bundle size changes comparing 97b62fb...c1755db |
oliviertassinari
approved these changes
Oct 16, 2020
packages/material-ui/src/ImageListItemBar/ImageListItemBar.test.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For image sources please use
fake.pngorfake2.pngif you don't care about the network request in browser tests.In browser test network requests are actually triggered (e.g. with
<img src="fake.png" />) which logs a warning. So far we're not actually testing the impact of these requests (as far as I can tell) so the warnings are just noise. With their color they're a bit distracting so I added two empty images that act as fake placeholders.Before: https://app.circleci.com/pipelines/github/mui-org/material-ui/24352/workflows/7ff12a01-f5d2-4e11-9cbf-c2b3468be9db/jobs/187515
After: https://app.circleci.com/pipelines/github/mui-org/material-ui/24351/workflows/9caed456-c9b9-4ae8-b3fb-5b6a380ae0fd/jobs/187511