-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[useIsFocusVisible] Remove focus-visible if focus is re-targetted #22102
Merged
eps1lon
merged 6 commits into
mui:next
from
eps1lon:fix/ButtonBase/focus-visible-retarget
Aug 9, 2020
Merged
[useIsFocusVisible] Remove focus-visible if focus is re-targetted #22102
eps1lon
merged 6 commits into
mui:next
from
eps1lon:fix/ButtonBase/focus-visible-retarget
Aug 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
bug 🐛
Something doesn't work
component: ButtonBase
The React component.
labels
Aug 7, 2020
Argos failure makes sense. It displayed all items as focus-visible but not it only displayes the last one as focus-visible. I'm pushing a visual change that will create a diff regardless of this bug fix. The diff due to this bug fix is visible in https://www.argos-ci.com/mui-org/material-ui/builds/2968 Though this test revealed another bug that I'll try to fix. It's less |
eps1lon
force-pushed
the
fix/ButtonBase/focus-visible-retarget
branch
from
August 7, 2020 19:48
90c51fd
to
6a4ca14
Compare
eps1lon
added
breaking change
package: material-ui
Specific to @mui/material
and removed
component: ButtonBase
The React component.
labels
Aug 8, 2020
eps1lon
changed the title
[ButtonBase] Remove focus-visible if focus is re-targetted
[useIsFocusVisible] Remove focus-visible if focus is re-targetted
Aug 8, 2020
oliviertassinari
approved these changes
Aug 8, 2020
github-actions
bot
added
PR: out-of-date
The pull request has merge conflicts and can't be merged
and removed
PR: out-of-date
The pull request has merge conflicts and can't be merged
labels
Aug 8, 2020
2 tasks
42 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Observed this bug a couple of times but wasn't able to understand/reproduce it. Saw it again in #22062 but this time reproducible:
the focus marker is still focus-visible but focus is on the the focus trap. Only every second click removes the focus-visible style:
Added a test that mimics TrapFocus to prevent future regression.