Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TrapFocus] Add documentation #22062

Merged
merged 6 commits into from
Aug 8, 2020
Merged

[TrapFocus] Add documentation #22062

merged 6 commits into from
Aug 8, 2020

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 3, 2020 •
edited
Loading

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation component: FocusTrap The React component. labels Aug 3, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Aug 3, 2020 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 646f0a5

@github-actions github-actions bot mentioned this pull request Aug 3, 2020
Closed
@eps1lon eps1lon mentioned this pull request Aug 4, 2020
Closed
1 task
mbrookes
mbrookes previously requested changes Aug 6, 2020
View reviewed changes
docs/src/pages/components/trap-focus/trap-focus.md Outdated Show resolved Hide resolved
docs/src/pages/components/trap-focus/trap-focus.md Outdated Show resolved Hide resolved
docs/src/pages/components/trap-focus/trap-focus.md Outdated Show resolved Hide resolved
docs/src/pages/components/trap-focus/trap-focus.md Outdated Show resolved Hide resolved
docs/src/pages/components/trap-focus/trap-focus.md Outdated Show resolved Hide resolved
docs/src/pages/components/trap-focus/trap-focus.md Outdated Show resolved Hide resolved
docs/src/pages/components/trap-focus/trap-focus.md Outdated Show resolved Hide resolved
@oliviertassinari @mbrookes
Matt code review
f19b53b 
Co-authored-by: Matt <[email protected]>
eps1lon
eps1lon previously requested changes Aug 6, 2020
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing.

@oliviertassinari oliviertassinari dismissed stale reviews from mbrookes and eps1lon August 6, 2020 11:57

Updated

eps1lon
eps1lon previously requested changes Aug 6, 2020
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page should have a big warning that this component is experimental.

eps1lon
eps1lon previously requested changes Aug 7, 2020
View reviewed changes
docs/src/pages/components/trap-focus/BasicTrapFocus.js Outdated Show resolved Hide resolved
docs/src/pages/components/trap-focus/trap-focus.md Outdated Show resolved Hide resolved
docs/src/pages/components/trap-focus/trap-focus.md Show resolved Hide resolved
docs/src/pages/components/trap-focus/trap-focus.md Outdated Show resolved Hide resolved
docs/src/pages/components/trap-focus/trap-focus.md Outdated Show resolved Hide resolved
@oliviertassinari oliviertassinari dismissed eps1lon’s stale review August 7, 2020 15:39

thanks for the review, I have updated the changes to take them into account

eps1lon
eps1lon approved these changes Aug 7, 2020
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Already found a bug with existing components 😄

@eps1lon eps1lon mentioned this pull request Aug 7, 2020
Merged
@oliviertassinari oliviertassinari merged commit 993a623 into mui:next Aug 8, 2020
@oliviertassinari oliviertassinari deleted the trap-focus-docs branch August 8, 2020 23:25
@oliviertassinari oliviertassinari mentioned this pull request Aug 8, 2020
Merged
@oliviertassinari oliviertassinari mentioned this pull request Nov 11, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshwooding joshwooding joshwooding approved these changes

@eps1lon eps1lon eps1lon approved these changes

@mbrookes mbrookes mbrookes approved these changes

Assignees
No one assigned
Labels
component: FocusTrap The React component. docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oliviertassinari @mui-pr-bot @mbrookes @eps1lon @joshwooding