[core] Use explicit html entity #15132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: bbfbb0c...9722821
|
oliviertassinari
added
core
and removed
docs
oliviertassinari
changed the title
oliviertassinari
approved these changes
Apr 2, 2019
oliviertassinari
force-pushed
the
docs/explicit-non-breaking-space
branch
from
c0a0c6d to
9722821
Compare
| @@ -85,7 +85,7 @@ const FormLabel = React.forwardRef(function FormLabel(props, ref) { | |||
| })} | |||
| data-mui-test="FormLabelAsterisk" | |||
| > | |||
| {'\u2009*'} | |||
|  {'*'} | |||
eps1lon
commented
Apr 2, 2019
eps1lon
commented
Apr 2, 2019
| @@ -18,14 +18,14 @@ import Avatar from '@material-ui/core/Avatar'; | |||
|
|
|||
| | Name | Type | Default | Description | | |||
| |:-----|:-----|:--------|:------------| | |||
| | <span class="prop-name">alt</span> | <span class="prop-type">string</span> | | Used in combination with `src` or `srcSet` to provide an alt attribute for the rendered `img` element. | | |||
There was a problem hiding this comment.
@oliviertassinari That's the old defaultValue right? I don't think that adds any value to the markdown. Should be fine with no space at all here.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something I didn't understand in #15115. I imagine that this can cause quite the frustration if people don't have these highlighted in their editor. I wish
no-irregular-whitespacewould catch these.