[core] Batch of fixes #15115
Merged
[core] Batch of fixes #15115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oliviertassinari
commented
Mar 30, 2019
•
oliviertassinari
commented
- Fix a prop type warning when rendering on the server
- Fix a UI jump on the home page
- Fix a table break of line issue with the demos
- Remove one flaky test from Argos
- Remove dead code (thanks to code coverage)
- Use US Engish over UK.
- Remove wrongly translated markdown files (in the premium themes)
| @@ -51,7 +50,7 @@ const styles = theme => ({ | |||
| root: { | |||
| backgroundColor: theme.palette.background.paper, | |||
| textAlign: 'center', | |||
| minHeight: 56, | |||
| minHeight: 60, | |||
There was a problem hiding this comment.
no UI jump during the hydratation.
| <CustomTableCell align="right">Fat (g)</CustomTableCell> | ||
| <CustomTableCell align="right">Carbs (g)</CustomTableCell> | ||
| <CustomTableCell align="right">Protein (g)</CustomTableCell> | ||
| <CustomTableCell align="right">Fat (g)</CustomTableCell> |
There was a problem hiding this comment.
unbreakable space
| @@ -128,7 +128,11 @@ function FilledInputAdornments() { | |||
| InputProps={{ | |||
| endAdornment: ( | |||
| <InputAdornment position="end"> | |||
| <IconButton aria-label="Toggle password visibility" onClick={handleClickShowPassword}> | |||
| <IconButton | |||
| edge="end" | |||
There was a problem hiding this comment.
Use the required edge property to match the specification.
| /** | ||
| * @ignore | ||
| */ | ||
| serverGenerateClassName: PropTypes.func, |
There was a problem hiding this comment.
Fix a PropType warning in the server.
| @@ -198,7 +198,7 @@ function makeStyles(stylesOrCreator, options = {}) { | |||
| ...stylesOptions2 | |||
| } = options; | |||
| const stylesCreator = getStylesCreator(stylesOrCreator); | |||
| const classNamePrefix = name || classNamePrefixOption || 'Hook'; | |||
| const classNamePrefix = name || classNamePrefixOption || 'makeStyles'; | |||
There was a problem hiding this comment.
Match the hook API name.
| @@ -175,7 +175,7 @@ export function getLuminance(color) { | |||
| } | |||
|
|
|||
| /** | |||
| * Darken or lighten a colour, depending on its luminance. | |||
| * Darken or lighten a color, depending on its luminance. | |||
| @@ -16,22 +16,6 @@ export function contains(obj, pred) { | |||
| return Object.keys(pred).every(key => obj.hasOwnProperty(key) && obj[key] === pred[key]); | |||
| } | |||
|
|
|||
| export function findIndex(arr, pred) { | |||
There was a problem hiding this comment.
Dead code (I have found it thanks to the test coverage!)
oliviertassinari
force-pushed
the
batch-fixes
branch
from
392a8f9 to
a96cb07
Compare
Details of bundle changes.Comparing: 2dedcc1...154d293
|
oliviertassinari
force-pushed
the
batch-fixes
branch
from
a96cb07 to
154d293
Compare
|
Could you write a summary what you fixed? |
|
Sure, I have updated the pull request description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.