#3015 fix insurance policy outgoing sync formatting

[wlthomson]

Fixes #3015.

Change summary

Fixes formatting of policy numbers synced from mobile to desktop.

Testing

Steps to reproduce or otherwise test the changes of this PR:

• Policies with personal numbers are correctly formatted after being synced from mobile to desktop (familyNumber-personalNumber).
• Policies without personal numbers are correctly formatted after being synced from mobile to desktop (familyNumber).

Related areas to think about

N/A.

[josh-griffin]

im confused a little bit soz!

[josh-griffin]

both values are required in the schema aren't they?

https://github.com/openmsupply/mobile/blob/d515a274516ae0b1b434add43eb967e4d94f8ad4/src/database/DataTypes/InsurancePolicy.js#L15-L16

🤔

[wlthomson]

Yeah, I believe that just means it can't be set to null or undefined? As it's a primitive I think it makes more sense to have it initialised to a falsey but non-null value?

To make it more explicit can do:

policyNumberPerson: { type: 'string', default: '' };

but I think the above is equivalent to the existing declaration?

[josh-griffin]

I didn't know so I did a quick test with:

UIDatabase.write(() => {
      const insuranceProvider = UIDatabase.update('InsuranceProvider', {
        id: '1',
      });

      UIDatabase.update('InsurancePolicy', { id: '1', insuranceProvider });
    });

And got the error "Missing value for property InsurancePolicy.policyNumberFamily" - so I believe you need to explicitly set the default. Also doesn't say anything in the docs about defaults being set for primitives automatically: https://realm.io/docs/javascript/latest/#default-property-values

[wlthomson]

Oops, looks like I misinterpreted the examples in the docs (I guess that includes implicitly on construction).

eeb4b8c.

[josh-griffin]