Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insurance: "-" should not be added in absence of Family Policy Number #3015

Closed
ArpitaSussol opened this issue Jul 10, 2020 · 2 comments
Closed

Insurance: "-" should not be added in absence of Family Policy Number #3015

ArpitaSussol opened this issue Jul 10, 2020 · 2 comments
Assignees
@wlthomson
Labels
Docs: not needed Effort: small Small effort story/task, estimated 0-2 days

Comments

@ArpitaSussol
Copy link

Describe the bug

"-" should not be added in absence of Family Policy Number

To reproduce

Steps to reproduce the behavior:

  1. Go to Mobile apk -> create a Prescription
  2. Add an insurance such that Family Policy number is blank/empty
  3. Finalize and sync
  4. GO to Desktop store. Check the following prescription
  5. See error. "-" is shown as prefix to Personal Policy Number
    Screen Shot 2020-07-10 at 12 02 12 PM

Expected behaviour

"-" should be removed in absence of Family Policy Number

Proposed Solution

Leave if you don't know how to fix/implement. Edit this issue description and explain here if you know the best path of implementing the fix within the codebase.

Version and device info

  • App version: 5.1.1
  • Tablet model:
  • OS version:

Additional context

arises while testing #2918
@ArpitaSussol ArpitaSussol added Docs: not needed Effort: small Small effort story/task, estimated 0-2 days Module: dispensary labels Jul 10, 2020
@ArpitaSussol ArpitaSussol mentioned this issue Jul 10, 2020
Closed
@wlthomson wlthomson self-assigned this Jul 14, 2020
This was referenced Jul 15, 2020
Merged
Closed
wlthomson added a commit that referenced this issue Jul 21, 2020
@wlthomson
Merge pull request #3030 from openmsupply/#3015-fix-insurance-policy-…
d29cdb2 
…outgoing-sync-formatting

#3015 fix insurance policy outgoing sync formatting
@wlthomson
Copy link
Contributor

Fixed by #3030.

@wlthomson wlthomson mentioned this issue Aug 5, 2020
Merged
@ArpitaSussol
Copy link
Author

Tested in V6.0.0 rc3

Testing

Steps to reproduce or otherwise test the changes of this PR:

  • Policies with personal numbers are correctly formatted after being synced from mobile to desktop (familyNumber-personalNumber). - PASS
  • Policies without personal numbers are correctly formatted after being synced from mobile to desktop (familyNumber). - PASS

@ArpitaSussol ArpitaSussol mentioned this issue Aug 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wlthomson wlthomson

Labels
Docs: not needed Effort: small Small effort story/task, estimated 0-2 days
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wlthomson @ArpitaSussol