Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exposes --cov param #17

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

zlskidmore
Copy link

removes hardcoding of --cov param to NULL and small bug fix where seg2gr complains that list is not supplied

@ShaiberAlon
Copy link
Collaborator

@zlskidmore , thank you for this pull request. Did you try this fix with your data? Did it work for you?

@zlskidmore
Copy link
Author

not yet, I am digging further into it today. I am still getting a "index out of bounds error"

@zlskidmore
Copy link
Author

zlskidmore commented Dec 7, 2021

@ShaiberAlon I did get this working, the remaining issues were calls to gr.sub that had to be commented out. I had modified the GC and MAP files to correspond to my bam files and subsequently my coverage files which all are chr1, chr2..... It looks like gr.sub is called on the gc and map files regardless of the coverage input (but is not called on the coverage input at all).

Happy to put in a pull request for this as well, but there are a couple of ways to go about it and I wasn't sure if there was a preference on how to handle this type of situation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants