Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reports dryclean in read count units and input signal retained in outputs #35

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

jrafailov
Copy link
Collaborator

Description:

  • foreground was previously reported in linear space, mean/median-normalized to 1
  • foreground is now reported in read count units.... or in the correct units relative to input field (fragcounter reads)

Changes:

  • migrated centering of sample to prep_cov
  • input.read.counts contains the raw input signal

Impact:

  • allows for downstream aggregation of coverage based on dryclean outputs alone as input signal is retained in the outputs
  • represents final foreground in same units as input signal

@jrafailov jrafailov merged commit d388155 into mskilab-org:master Sep 11, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant