Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory mindful patch to PON generation #24

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Memory mindful patch to PON generation #24

merged 1 commit into from
Nov 28, 2023

Conversation

jrafailov
Copy link
Collaborator

Description:

  • Patch for memory ballooning during PON generation
  • Original code had an inefficient and unnecessary matrix transposition that impeded generation of large PONs (n > 600)

Changes:

  • Refactoring of ~10 lines of code

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #24 (283952d) into master (ff1e15f) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   78.91%   78.80%   -0.12%     
==========================================
  Files           3        3              
  Lines         555      552       -3     
==========================================
- Hits          438      435       -3     
  Misses        117      117              
Files Coverage Δ
R/dryclean.R 77.57% <100.00%> (-0.18%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff1e15f...283952d. Read the comment docs.

@sebastian-brylka sebastian-brylka merged commit 5661fba into mskilab-org:master Nov 28, 2023
4 checks passed
Copy link
Collaborator

@sebastian-brylka sebastian-brylka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants