Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed rebinning problem + added masking #23

Merged
merged 3 commits into from
Nov 21, 2023
Merged

fixed rebinning problem + added masking #23

merged 3 commits into from
Nov 21, 2023

Conversation

sebastian-brylka
Copy link
Collaborator

Fixed rebinning problem:

  • if the bin size of coverage does not match pon's template, automatically rebin to match the pon bins
  • achieved by gr.val function with pon template as query
  • if the bin sizes match but the number of bins do not, stop execution

Added masking functionality

  • allow user to provide a mask so that some regions of the coverage do not get drycleaned
  • if use.blacklist = TRUE but blacklist.path remains unspecified, applied a default mask
  • mask both coverage and pon before the drycleaning to match dimensions
  • if the mask was applied, clean function returns the coverage of the same ranges as the original coverage but all the values in the masked regions are set to NA

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #23 (6cd8f9b) into master (ce4d204) will decrease coverage by 7.43%.
Report is 3 commits behind head on master.
The diff coverage is 26.92%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   86.34%   78.91%   -7.43%     
==========================================
  Files           3        3              
  Lines         520      555      +35     
==========================================
- Hits          449      438      -11     
- Misses         71      117      +46     
Files Coverage Δ
R/helper_functions.R 75.00% <25.00%> (ø)
R/dryclean.R 77.74% <27.02%> (-10.74%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b87aefd...6cd8f9b. Read the comment docs.

@sebastian-brylka sebastian-brylka merged commit ff1e15f into master Nov 21, 2023
2 of 4 checks passed
@sebastian-brylka sebastian-brylka deleted the sb_dev branch November 28, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant