Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: introduce ShadowNode #29567

Merged
merged 4 commits into from
Oct 6, 2024
Merged

WebGPURenderer: introduce ShadowNode #29567

merged 4 commits into from
Oct 6, 2024

Conversation

aardgoose
Copy link
Contributor

Related issue: #29515

Separate the shadow map creation and use from AnalyticLightNode to create a point where a shadow partitioning node can be inserted to allow implementation for cascading shadow maps and other techniques.

Copy link

github-actions bot commented Oct 6, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 688.12
170.5
688.12
170.5
+0 B
+0 B
WebGPU 807.64
217.51
807.93
217.62
+292 B
+107 B
WebGPU Nodes 807.15
217.38
807.44
217.48
+292 B
+105 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.84
111.78
462.84
111.78
+0 B
+0 B
WebGPU 535.43
144.5
535.68
144.56
+252 B
+61 B
WebGPU Nodes 491.54
134.24
491.79
134.31
+252 B
+72 B

@sunag sunag added this to the r170 milestone Oct 6, 2024
@sunag sunag merged commit b378fba into mrdoob:dev Oct 6, 2024
12 checks passed
@aardgoose aardgoose deleted the shadow branch October 10, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants