Nodes: Only use PMREM for background when blurriness is configured. #29089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
commented
Aug 8, 2024
|
|
||
| const currentMRT = renderer.getMRT(); | ||
| renderer.setMRT( null ); | ||
|
|
||
| camera.update( renderer, scene ); |
There was a problem hiding this comment.
CubeCamera.update() isn't MRT compatible so I fixed CubeRenderTarget here.
There was a problem hiding this comment.
We have renderer state definition and restoration in many places, I was thinking about having a way to automate this otherwise every new feature related will break the chain of nodes that use beforeUpdate() to render().
Mugen87
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #28827.
Description
PMREM is now only used for the background when blurriness is defined. Otherwise the cube map format is used like in
WebGLRendererwhich should fix the quality differences mentioned in #28827.