Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPURenderer: Apply Scene.environment only on PBR materials. #29033

Merged
merged 1 commit into from
Aug 1, 2024
Merged

WebGPURenderer: Apply Scene.environment only on PBR materials. #29033

merged 1 commit into from
Aug 1, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 31, 2024

Fixed #29031.

Description

This should make sure Scene.environment only affects physical materials.

@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
684 kB (169.4 kB) 684 kB (169.4 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
460.9 kB (111.2 kB) 460.9 kB (111.2 kB) +0 B

@Mugen87 Mugen87 added this to the r168 milestone Jul 31, 2024
@Mugen87 Mugen87 merged commit f4c997e into mrdoob:dev Aug 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r168
Development

Successfully merging this pull request may close these issues.

MeshBasicNodeMaterial bug with scene.environment
1 participant
@Mugen87