Replace pycrypto with pycryptodome #43
Conversation
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
- Coverage 95.53% 95.35% -0.19%
==========================================
Files 7 7
Lines 538 538
==========================================
- Hits 514 513 -1
- Misses 24 25 +1
Continue to review full report at Codecov.
|
|
@mpdavis did you have a chance to look at this? Maybe I'm mistaken, but the code coverage change doesn't look significant. |
|
One of the core philosophies of this repo is Google AppEngine support, which doesn't support pycryptodome over pycrypto. #42 was just merged, which adds support for runtime algorithm registration. I am a fan of safe defaults, so I would be happy with using pycryptodome as the default as long as there was an option to switch back to pycrypto so that we can support GAE. |
ghost
mentioned this pull request
Continue to push for `pycryptodome` as the default, but add some GAE detection for intallation requirements. If installing on GAE, should continue to use pycrypto. Closes mpdavis#43
Continue to push for `pycryptodome` as the default, but add some GAE detection for intallation requirements. If installing on GAE, should continue to use pycrypto. Closes mpdavis#43
|
Closing in favor of #57 |
pycryptohas vulnerabilities pointed out at least as early as Dec 30, 2015, and the repo hasn't accept PRs since June 23, 2014.pycryptodomeis a drop-in replacement that's actively maintained and compatible with Python > 2.4.python-josealready had an option to use it for PyPy, this merely makes it the default everywhere.