Use pycryptodome, allowing the use of pycrypto on GAE #64
Conversation
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
- Coverage 94.53% 94.41% -0.12%
==========================================
Files 12 12
Lines 841 841
==========================================
- Hits 795 794 -1
- Misses 46 47 +1
Continue to review full report at Codecov.
|
|
I can mock over the @mpdavis, maybe you want to set a |
Continue to push for `pycryptodome` as the default, but add some GAE detection for intallation requirements. If installing on GAE, should continue to use pycrypto. Closes mpdavis#43
sirosen
force-pushed
the
use-pycryptodome
branch
from
034f93d to
f1f46bf
Compare
|
I've just validated that this installs correctly on GAE. EDIT: I'm not actually sure whether or not my GAE validation was sufficient, being a novice in its use. I was able to install in the Google Cloud Shell, which I thought was the same environment as GAE, but I now notice that it actually installed |
|
@mpdavis, a coworker just pointed out to me that If this detection isn't satisfactory, I'm happy to swap it out for something else, but not being a GAE user it's hard to be confident in my testing. |
|
That certainly would push us towards getting off of I can look into testing this and getting it in. We will need some way to handle this. |
@mpdavis, is this method of GAE detection satisfactory?
I'm not an appengine user myself, so not ready to test, but I am interested in #43 getting merged.
Replaces / closes #43