Fix async wake behavior #1785
Merged
Fix async wake behavior #1785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendk
requested review from
mhammond and
jplatte
and removed request for
a team
bendk
force-pushed
the
async-wake-fix
branch
2 times, most recently
from
6e2a088 to
8284621
Compare
If wake() is called while we are in the middle of polling a future, then we should immediately call our continuation function to schedule another poll.
jplatte
approved these changes
Oct 11, 2023
|
cc @Hywan |
|
Empirically, this seems to fix all of our problems with the rewritten async methods! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If wake() is called while we are in the middle of polling a future, then we should immediately call our continuation function to schedule another poll.