Upgrade UniFFI #2661
Merged
Upgrade UniFFI #2661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2661 +/- ##
=======================================
Coverage 78.61% 78.61%
=======================================
Files 192 192
Lines 20146 20146
=======================================
Hits 15837 15837
Misses 4309 4309 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Oct 4, 2023
This comment was marked as resolved.
This comment was marked as resolved.
jplatte
force-pushed
the
jplatte/bump-uniffi
branch
from
50b04b9 to
68a42cc
Compare
bnjbvr
approved these changes
Oct 5, 2023
jplatte
force-pushed
the
jplatte/bump-uniffi
branch
from
68a42cc to
439b417
Compare
|
Now updated to point at mozilla/uniffi-rs#1785 |
jplatte
force-pushed
the
jplatte/bump-uniffi
branch
3 times, most recently
from
cc655b2 to
5ce2c17
Compare
|
mozilla/uniffi-rs#1785 plus smol-rs/async-compat#22 fixed the Android issues! 🎉 |
|
… and I got confirmation that it works well on iOS too! |
jplatte
force-pushed
the
jplatte/bump-uniffi
branch
from
5ce2c17 to
a4f8531
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in a large refactoring of
async fnlowering. Needs manual testing for both iOS & Android.