Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Taskgraph 7 #316

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Upgrade to Taskgraph 7 #316

merged 2 commits into from
Dec 21, 2023

Conversation

bhearsum
Copy link
Collaborator

@bhearsum bhearsum commented Dec 18, 2023

Two things of note:

  • ci directory becomes kinds
  • taskcluster/ci/config.yml moves to taskcluster/config.yml

This version also includes some changes to cache routes for PRs which should fix #301.

@bhearsum bhearsum requested a review from a team as a code owner December 18, 2023 21:08
@bhearsum bhearsum requested a review from jcristau December 18, 2023 21:08
@bhearsum
Copy link
Collaborator Author

taskgraph --diff is broken here because when it's trying to generate a task graph with the new taskgraph code, but without the necessary changes to kinds, config.yml, etc. This is, unfortunately, unavoidable (taskgraph --diff is unable to downgrade itself when generating the older task graph...)

@bhearsum bhearsum requested review from ahal and eu9ene and removed request for a team and jcristau December 19, 2023 01:04
@bhearsum
Copy link
Collaborator Author

This PR is as green as it will get - fails for the reason I mentioned, and the clean steps are failing due to #292

Copy link
Member

@ahal ahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fyi I've also been updating to the latest Decision image as part of these upgrades. But it's totally reasonable to do that separately.

@bhearsum bhearsum merged commit d7f725e into mozilla:main Dec 21, 2023
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PRs are not always picking up cached tasks
2 participants