Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tasks are not cached for pull request CI #225

Closed
eu9ene opened this issue Oct 17, 2023 · 2 comments
Closed

The tasks are not cached for pull request CI #225

eu9ene opened this issue Oct 17, 2023 · 2 comments
Labels
cost & perf Speeding up and lowering cost for the pipeline taskcluster Issues related to the Taskcluster implementation of the training pipeline

Comments

@eu9ene
Copy link
Collaborator

eu9ene commented Oct 17, 2023

I would expect the following behavior: if all the data and code files that serve as a step input (including ci kinds and transforms) are unchanged, it should use the cached output. Sometimes you want to debug the last step of the pipeline on taskcluster and CI is a convenient way to do that. Then it shouldn’t rerun the whole thing every time. It adds to costs and wait time.

Also, the cache should be reused across all the PRs/runs. I don't see any risks with that as soon as we can trust the caching mechanism to take into account everything that affects the output.

@eu9ene eu9ene added taskcluster Issues related to the Taskcluster implementation of the training pipeline cost & perf Speeding up and lowering cost for the pipeline labels Oct 17, 2023
@bhearsum
Copy link
Collaborator

I agree this is something that we should do. Even with the much speedier CI runs we have now, there's no reason to re-run things we've already done in another PR.

I don't think we can safely do this until we're using level 3 workers for real training runs again. At the moment, both real training runs and PRs use the "level 1" cache, which means that if we allow PRs to add things to the cache, it could potentially pollute things for real runs.

@eu9ene
Copy link
Collaborator Author

eu9ene commented Feb 15, 2024

It's fixed now after this has landed.

@eu9ene eu9ene closed this as completed Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cost & perf Speeding up and lowering cost for the pipeline taskcluster Issues related to the Taskcluster implementation of the training pipeline
Projects
None yet
Development

No branches or pull requests

2 participants